Merge pull request #36 from jglick/printStackTrace-JDK-6507809

Use Functions.printThrowable to provide more legible stack traces in 2.43+

Author: jglick

src/main/java/org/jenkinsci/plugins/workflow/steps/CatchErrorStep.java

@@ -27,6 +27,7 @@
 import com.google.common.collect.ImmutableSet;
 import hudson.AbortException;
 import hudson.Extension;
+import hudson.Functions;
 import hudson.model.Result;
 import hudson.model.Run;
 import hudson.model.TaskListener;
@@ -106,7 +107,7 @@ private static final class Callback extends BodyExecutionCallback {
                         fie.handle(context.get(Run.class), listener);
                         r = fie.getResult();
                     } else {
-                        t.printStackTrace(listener.getLogger());
+                        listener.getLogger().println(Functions.printThrowable(t).trim()); // TODO 2.43+ use Functions.printStackTrace
                     }
                     context.get(Run.class).setResult(r);
                     context.onSuccess(null);

src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java

@@ -2,6 +2,7 @@
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.AbortException;
+import hudson.Functions;
 import hudson.model.TaskListener;
 import jenkins.model.CauseOfInterruption;
 
@@ -76,7 +77,7 @@ public void onFailure(StepContext context, Throwable t) {
                     if (t instanceof AbortException) {
                         l.error(t.getMessage());
                     } else {
-                        t.printStackTrace(l.error("Execution failed"));
+                        l.error("Execution failed").println(Functions.printThrowable(t).trim()); // TODO 2.43+ use Functions.printStackTrace
                     }
                     l.getLogger().println("Retrying");
                     context.newBodyInvoker().withCallback(this).start();