fixed depth estimation during drift map plotting#10
Open
zhangxiaoxing wants to merge 1 commit intojenniferColonell:masterfrom
Open
fixed depth estimation during drift map plotting#10zhangxiaoxing wants to merge 1 commit intojenniferColonell:masterfrom
zhangxiaoxing wants to merge 1 commit intojenniferColonell:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter signature for the "get_spike_depths" method in the common.utils module was updated (twice) through 2021, while its usage in the commons.visualization module is not updated since 2019, causing the commons.visualization.plotDriftmap() function to fail when called. This patch corrected the problem.