fix: move to rrule-temporal v2 and drop the @js-temporal override#525
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Changesrrule-temporal v2 migration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks @thomasbachem for this PR. I am almost about to merge #523 and once this is done I would be happy to see this PR being rebased and updated for the improvements to quickly be merged afterwards. |
|
Sounds good – I'll rebase and update as soon as #523 lands. |
|
@thomasbachem #523 is merged now. So feel free to rebase this PR with your proposed changes. |
rrule-temporal v2 dropped @js-temporal/polyfill, so the overrides entry has nothing left to redirect. Since overrides only applies at the root project, consumers kept resolving @js-temporal/polyfill and jsbi regardless. This drops both from their trees too.
a7230b8 to
a078310
Compare
|
Rebased onto master now that #523 has landed – same change, re-applied on the ESM-rewritten test file: v2 bump, 195 -> 193 tests, green on Node 22, 24 and 26 (native Temporal on 26). |
rrule-temporalv2.0.0 dropped@js-temporal/polyfill, so theoverridesentry from #442 has nothing left to redirect.As #524 explains,
overridesonly applies at the root project, so consumers kept resolving@js-temporal/polyfillandjsbiregardless – this drops both from their trees, not only from this repo's.rrule-temporal^1.5.3->^2.0.0overridesremovedtest/polyfill-check.test.jscases asserting that@js-temporal/polyfillresolves totemporal-polyfill– it is no longer in the tree at all. The JSBI check stays and now passes on its own terms195 -> 193 tests, green on Node 22, 24 and 26.
test:typesandxoclean.I have not touched v2's other breaking changes (
all()memoization, andnext()/previous()now starting near the query point rather than atDTSTART). No test here depends on either, but they do change behaviour for anyone relying on the old iteration semantics.Fixes #524
Summary by CodeRabbit
Chores
Tests
jsbipackage is not installed.