Skip to content

fix: move to rrule-temporal v2 and drop the @js-temporal override#525

Merged
jens-maus merged 2 commits into
jens-maus:masterfrom
thomasbachem:fix/rrule-temporal-v2
Jul 19, 2026
Merged

fix: move to rrule-temporal v2 and drop the @js-temporal override#525
jens-maus merged 2 commits into
jens-maus:masterfrom
thomasbachem:fix/rrule-temporal-v2

Conversation

@thomasbachem

@thomasbachem thomasbachem commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

rrule-temporal v2.0.0 dropped @js-temporal/polyfill, so the overrides entry from #442 has nothing left to redirect.

As #524 explains, overrides only applies at the root project, so consumers kept resolving @js-temporal/polyfill and jsbi regardless – this drops both from their trees, not only from this repo's.

  • rrule-temporal ^1.5.3 -> ^2.0.0
  • overrides removed
  • Dropped the two test/polyfill-check.test.js cases asserting that @js-temporal/polyfill resolves to temporal-polyfill – it is no longer in the tree at all. The JSBI check stays and now passes on its own terms

195 -> 193 tests, green on Node 22, 24 and 26. test:types and xo clean.

I have not touched v2's other breaking changes (all() memoization, and next()/previous() now starting near the query point rather than at DTSTART). No test here depends on either, but they do change behaviour for anyone relying on the old iteration semantics.

Fixes #524

Summary by CodeRabbit

  • Chores

    • Updated the recurring-rules package to a newer major version.
  • Tests

    • Simplified compatibility checks while continuing to verify that the unnecessary jsbi package is not installed.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f066a2bc-e973-4b31-9e57-990809b9fe64

📥 Commits

Reviewing files that changed from the base of the PR and between a7230b8 and a078310.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json
  • test/polyfill-check.test.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

📝 Walkthrough

Walkthrough

The rrule-temporal dependency is upgraded from 1.5.3 to 2.0.0. Polyfill tests are reduced to the JSBI absence check, removing obsolete CommonJS resolution setup and @js-temporal/polyfill assertions.

Changes

rrule-temporal v2 migration

Layer / File(s) Summary
Dependency upgrade and polyfill test cleanup
package.json, test/polyfill-check.test.js
rrule-temporal is upgraded to v2, while obsolete @js-temporal/polyfill resolution/loading checks and their CommonJS setup are removed. The JSBI absence check remains.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately summarizes the dependency bump and override cleanup.
Linked Issues check ✅ Passed The rrule-temporal v2 bump addresses the consumer polyfill issue by removing the @js-temporal/polyfill dependency path.
Out of Scope Changes check ✅ Passed The test removals and package update are directly tied to the dependency bump; no unrelated changes are evident.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jens-maus

Copy link
Copy Markdown
Owner

Thanks @thomasbachem for this PR. I am almost about to merge #523 and once this is done I would be happy to see this PR being rebased and updated for the improvements to quickly be merged afterwards.

@thomasbachem

Copy link
Copy Markdown
Contributor Author

Sounds good – I'll rebase and update as soon as #523 lands.

@jens-maus

Copy link
Copy Markdown
Owner

@thomasbachem #523 is merged now. So feel free to rebase this PR with your proposed changes.

rrule-temporal v2 dropped @js-temporal/polyfill, so the overrides
entry has nothing left to redirect. Since overrides only applies at the
root project, consumers kept resolving @js-temporal/polyfill and jsbi
regardless. This drops both from their trees too.
@thomasbachem
thomasbachem force-pushed the fix/rrule-temporal-v2 branch from a7230b8 to a078310 Compare July 19, 2026 01:37
@thomasbachem

Copy link
Copy Markdown
Contributor Author

Rebased onto master now that #523 has landed – same change, re-applied on the ESM-rewritten test file: v2 bump, overrides removed, the two override-asserting polyfill-check cases dropped.

195 -> 193 tests, green on Node 22, 24 and 26 (native Temporal on 26). test:types and xo clean.

@KristjanESPERANTO KristjanESPERANTO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jens-maus
jens-maus merged commit b2225ce into jens-maus:master Jul 19, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@js-temporal/polyfill override doesn't reach consumers

3 participants