fix: forward step response to action criteria evaluation context#144
Open
HimethW wants to merge 2 commits into
Open
fix: forward step response to action criteria evaluation context#144HimethW wants to merge 2 commits into
HimethW wants to merge 2 commits into
Conversation
…de/$response evaluation
There was a problem hiding this comment.
Pull request overview
This PR fixes conditional flow-control actions (goto, end, retry) being skipped when their criteria expressions reference $statusCode / $response, by forwarding the step HTTP response down into the action-criteria evaluation context.
Changes:
- Forward the current step’s
responsefromArazzoRunner.execute_next_stepintoStepExecutor.determine_next_action. - Thread the
responsethroughActionHandler.determine_next_actioninto_check_action_criteria. - Populate the action-criteria evaluation context with
statusCodeandresponsederived from the step response.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| runner/arazzo_runner/runner.py | Passes step_result["response"] into next-action determination. |
| runner/arazzo_runner/executor/step_executor.py | Extends determine_next_action to accept/forward the step response. |
| runner/arazzo_runner/executor/action_handler.py | Extends action evaluation APIs and builds criteria evaluation context from the response. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where conditional actions (
goto,end,retry) silently fail when their nestedcriteriablock tries to evaluate$statusCodeor$response. It updates the execution chain to forward the HTTP response object into the evaluation context.Testing
pytestsuite.2 failed, 309 passed, 8 skipped, 2 warnings in 4.36sv0.9.6/mainbranch on Windows, confirming they are baseline environment discrepancies and completely unrelated to this change.Fixes #143