Skip to content

fix- modal jumping height#503

Open
jlsajfj wants to merge 1 commit into
jeremybarbet:masterfrom
jlsajfj:master
Open

fix- modal jumping height#503
jlsajfj wants to merge 1 commit into
jeremybarbet:masterfrom
jlsajfj:master

Conversation

@jlsajfj

@jlsajfj jlsajfj commented May 17, 2024

Copy link
Copy Markdown

DragY is being reset somewhere- causes modal to jump around. Workaround is to set it again at the start of handleAnimateOpen

#498 (comment)

@iancartis

Copy link
Copy Markdown

Hello <3,
We really need this to be fixed as we are using it on a production application.
Do we have any estimation on when this is going to be merged?

Thanks for all the amazing work!

@MilanMalovic

Copy link
Copy Markdown

Hi @jeremybarbet, w are currently using this functionality in a production, and resolving this issue would greatly improve the user experience. The workaround provided is helpful, but we would appreciate it if the fix could be officially integrated into the codebase.
Could you please provide an estimate on when the fix might be merged? We are eager to implement it as soon as possible to ensure smooth functionality in our app.

@Andrija00

Copy link
Copy Markdown

@jeremybarbet Can you merge this one please?

@jlsajfj

jlsajfj commented Dec 5, 2024

Copy link
Copy Markdown
Author

Anyone who needs this, just change your package.json to look like the following:

"react-native-modalize": "git+https://github.com/jlsajfj/react-native-modalize.git",

This should replace the version number.

@amerllica

Copy link
Copy Markdown

I just got the index change by directly modifying the node_modules and running npx patch-package react-native-modalize.

@jlsajfj

jlsajfj commented Apr 3, 2025

Copy link
Copy Markdown
Author

emailed him lol, hopefully merged soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants