Skip to content

fix pthash memory estimate #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jermp merged 2 commits into from
May 6, 2026
Merged

fix pthash memory estimate #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90ace87
Account for input hash vector in construction memory estimate
claude May 6, 2026
9600827
Drop the redundant in-search hashes term and the comment
claude May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/builders/internal_memory_builder_single_phf.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,10 @@ struct internal_memory_builder_single_phf {
num_buckets * sizeof(uint64_t) // pilots
+ num_buckets * sizeof(uint64_t) // buckets
+ (config.minimal ? (table_size - num_keys) * sizeof(uint64_t) : 0) // free_slots
+ num_keys * sizeof(uint64_t) // hashes
+ table_size / 8; // bitmap taken

return std::max<uint64_t>(num_bytes_for_map, num_bytes_for_search);
return std::max<uint64_t>(num_bytes_for_map, num_bytes_for_search) +
num_keys * sizeof(typename hasher_type::hash_type);
}

private:
Expand Down
Loading