add tests to fix to have a better cov

Author: jerryfinol17

pages/Login_Page.py

@@ -1,48 +1,32 @@
 from selenium.webdriver.support import expected_conditions as EC
 from pages.Base_Page import BasePage
 from config.locators import LOGIN
-
-
 class LoginPage (BasePage) :
-
     def open_page ( self ) :
         self.go_to ("https://www.saucedemo.com/")
         self.wait.until (EC.visibility_of_element_located (LOGIN["LOGIN_BUTTON"]))
         self.logger.info ("Login page opened successfully")
-
     def login ( self , username: str , password: str ) -> bool :
         try :
             self.fill (LOGIN["USERNAME_INPUT"] , username)
             self.fill (LOGIN["PASSWORD_INPUT"] , password)
             self.click (LOGIN["LOGIN_BUTTON"])
-
             self.logger.info (f"Login attempted with user: {username}")
             return True
         except Exception as e :
             self.logger.error (f"Login failed for user {username}: {e}")
             return False
-
     def get_error_message ( self ) -> str :
         try :
             return self.get_text (LOGIN["ERROR_MESSAGE"])
         except Exception :
             return ""
-
     def is_error_message_visible ( self ) -> bool :
         return self.is_visible (LOGIN["ERROR_MESSAGE"])
-
-    def logout ( self ) -> bool :
-        try :
-            self.click (LOGIN["MENU_BUTTON"])
-            self.click (LOGIN["LOGOUT_BUTTON"])
+    def logout ( self ) -> None :
+            self.click (LOGIN["BURGER_MENU_BUTTON"])
+            self.click (LOGIN["LOGOUT_LINK"])
             self.wait.until (EC.visibility_of_element_located (LOGIN["LOGIN_BUTTON"]))
-
-            self.logger.info ("Logout completed successfully")
-            return True
-        except Exception as e :
-            self.logger.error (f"Logout failed: {e}")
-            return False
-
     def is_login_button_visible ( self ) -> bool :
         return self.is_visible (LOGIN["LOGIN_BUTTON"])
 

test/conftest.py

@@ -33,7 +33,7 @@ def browser_driver(request):
 
     if browser_name == "firefox":
         options = FirefoxOptions ()
-        options.add_argument ("--headless")
+        options.add_argument ("--headed")
         options.add_argument ("--disable-notifications")
         options.add_argument ("--disable-gpu")
         options.page_load_strategy = "normal"

test/test_cart.py

@@ -90,7 +90,8 @@ def test_full_e2e_checkout(cart_page_with_items, first_name, last_name, postal_c
     with allure.step("Finalizar la compra"):
         assert checkout.complete_checkout() == True
         assert "checkout-complete.html" in checkout.driver.current_url
-        assert "Thank you for your order!" in checkout.driver.page_source
+        assert "Thank you for your order!" in checkout.get_complete_header_text()
+        assert checkout.is_complete_header_visible() == True
         print(f"E2E complete with user {first_name} {last_name}, final URL: {checkout.driver.current_url}")
 
     allure.attach(cart_page_with_items.driver.get_screenshot_as_png(), name="Checkout Complete",

test/test_login.py

@@ -11,10 +11,11 @@ def login_page(browser_driver, request):
     return login_page
 
 
-def test_successful_login(login_page):
+def test_successful_login_and_logout(login_page):
     with allure.step("Abrir página de login"):
         login_page.open_page()
-
+    with allure.step("Verificar que esta en la pagina de login"):
+        assert login_page.get_current_url() == "https://www.saucedemo.com/"
     with allure.step("Login con  username válido (standard_user)"):
         login_page.login(config_for_login_page.CREDENTIALS["standard_user"]["username"], config_for_login_page.CREDENTIALS["standard_user"]["password"])
 
@@ -23,6 +24,8 @@ def test_successful_login(login_page):
 
     with allure.step("Cerrar sesión para limpieza del test"):
         login_page.logout()
+    with allure.step("Verificar que el logout a traves del boton de login"):
+        assert login_page.is_login_button_visible() == True
 
 
 def test_locked_out_user(login_page):