Added jerry-ext amalgamation#4992
Closed
dmazzella wants to merge 2 commits into
Closed
Conversation
robertsipka
requested changes
Nov 25, 2024
robertsipka
left a comment
robertsipka
left a comment
Contributor
There was a problem hiding this comment.
Please rebase it with master, merge the commits into one and add the missing DCO to the end of the commit msg. Otherwise, it looks good to me.
gergocs
pushed a commit
to gergocs/jerryscript
that referenced
this pull request
Nov 29, 2024
Added option to enable jerry-ext amalgamation The implementation is based on PR jerryscript-project#4992. Only applied the requested changes and rebase to master. Co-authored-by: Damiano Mazzella damianomazzella@gmail.com JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu
gergocs
added a commit
to gergocs/jerryscript
that referenced
this pull request
Nov 29, 2024
Added option to enable jerry-ext amalgamation The implementation is based on PR jerryscript-project#4992. Only applied the requested changes and rebase to master. Co-authored-by: Damiano Mazzella damianomazzella@gmail.com JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu
Contributor
|
I'm closing it because the requests have been addressed here: #5184 |
LaszloLango
pushed a commit
that referenced
this pull request
Dec 3, 2024
Added option to enable jerry-ext amalgamation The implementation is based on PR #4992. Only applied the requested changes and rebase to master. Co-authored-by: Damiano Mazzella damianomazzella@gmail.com JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option to enable jerry-ext amalgamation