Implement operations of atomics#5166
Merged
Merged
Conversation
LaszloLango
requested changes
Nov 20, 2024
LaszloLango
left a comment
LaszloLango
left a comment
Contributor
There was a problem hiding this comment.
Could you please add more details into the commit message, what operations are implemented and what are still missing?
Contributor
|
Please add proper ifdef guards not to break non bigint build. See #5047 for details. |
LaszloLango
requested changes
Nov 25, 2024
The following methods were implemented: Atomics.compareExchange Atomics.store The implementation is based on PR jerryscript-project#4956, only resolved the conflicts. Co-authored-by: Csaba Repasi repasics@inf.u-szeged.hu JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following methods were implemented:
Atomics.compareExchange
Atomics.store
The implementation is based on PR #4956, only resolved the conflicts.
Co-authored-by: Csaba Repasi repasics@inf.u-szeged.hu
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu