Fix check-string.sh to check every generated strings#5179
Merged
robertsipka merged 1 commit intoNov 27, 2024
Conversation
The original implementation only checked lit-magic-strings.inc.h. This patch adds checking for ecma-error-messages.inc.h and parser-error-messages.inc.h This patch fixes jerryscript-project#5172 issue. JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu
gergocs
force-pushed
the
checkStringUpgrade
branch
from
November 27, 2024 11:45
463b62d to
29dbcd5
Compare
ossy-szeged
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original implementation only checked lit-magic-strings.inc.h. This patch adds checking for ecma-error-messages.inc.h and parser-error-messages.inc.h
This patch fixes #5172 issue.
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu