Skip to content

fix issue 111#112

Open
albanlorillard wants to merge 2 commits into
jessezach:masterfrom
albanlorillard:fix-111/fix-quote
Open

fix issue 111#112
albanlorillard wants to merge 2 commits into
jessezach:masterfrom
albanlorillard:fix-111/fix-quote

Conversation

@albanlorillard
Copy link
Copy Markdown

Hi @jessezach,

I have proposed a fix for this issue: #111. I haven't tested it yet as I'm not a Python developer, but I will look into how I can do this.

@albanlorillard
Copy link
Copy Markdown
Author

I successfully test my code, seems to be ok :
image

@jessezach
Copy link
Copy Markdown
Owner

Hi @albanlorillard, thanks for raising a fix. Is this issue only limited to quote? I'm guessing there could be other special characters where we could encounter the same issue.

@albanlorillard
Copy link
Copy Markdown
Author

albanlorillard commented Mar 23, 2025

Hello Jesse,
I've generalized it for every HTML character using the escape method from the html library, available since Python 3.4. I updated the PR.
However, there still seems to be an issue with the double quote (").

If you have any idea how to properly fix this particular case, I could integrate it into this PR.

@jessezach
Copy link
Copy Markdown
Owner

@albanlorillard Thanks for getting back. Do you have an example string that I can use to check?

@KuSh
Copy link
Copy Markdown

KuSh commented Jun 2, 2025

Thanks for getting back. Do you have an example string that I can use to check?

There's an example string in the issue: Affichage d'un masque but anything with a quote in it should do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants