fix(jest-mock): add construct signature to MockedClass#16189
Open
eyupcanakman wants to merge 2 commits into
Open
fix(jest-mock): add construct signature to MockedClass#16189eyupcanakman wants to merge 2 commits into
eyupcanakman wants to merge 2 commits into
Conversation
MockedClass had a call signature but no `new` signature, so constructing a mocked class returned the original instance type instead of a mocked one. Add a construct signature returning Mocked<InstanceType<T>>. Closes jestjs#14458
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14458.
const M = Foo as Mocked<typeof Foo>; const x = new M();typedxasFoo, not a mocked instance, sox.method.mockwas not visible.MockedClass<T>had a call signature but nonewsignature, sonewfell through to the original constructor viaMockedObject<T>.The fix adds a construct signature returning
Mocked<InstanceType<T>>, matching the existing call signature.Classes with overloaded constructors still resolve to the original type, since
MockedObject<T>includes the raw class and its construct signatures take precedence. Single-constructor classes, including the reported case, are fixed.Test plan
yarn test-typesfor jest-mock. The existing class type test inMocked.test.tsdrops a now-unnecessary cast and asserts the constructed instance isMocked<InstanceType<typeof MockSomeClass>>; it fails without the signature and passes with it.