[refactor] Run gofumpt, enforcer in CICD (#417)

## Summary

TSIA

## How was it tested?

Author: mikeland73

.github/workflows/monorepo-go.yml

@@ -47,5 +47,10 @@ jobs:
       - name: Build
         run: devbox run build
 
+      - name: Format
+        run: |
+          devbox run fmt
+          git diff --exit-code
+
       - name: Test
         run: devbox run test

pkg/auth/internal/tokenstore/io.go

@@ -23,7 +23,7 @@ func issuerSlug(issuer string) string {
 
 func ensureDir(path string) error {
 	dir := filepath.Dir(path)
-	return os.MkdirAll(dir, 0700)
+	return os.MkdirAll(dir, 0o700)
 }
 
 func writeJSONFile(path string, value storeData) error {
@@ -36,7 +36,7 @@ func writeJSONFile(path string, value storeData) error {
 	if err != nil {
 		return errors.WithStack(err)
 	}
-	return errors.WithStack(os.WriteFile(path, data, 0644))
+	return errors.WithStack(os.WriteFile(path, data, 0o644))
 }
 
 func readJSONFile(path string, value *storeData) error {

pkg/auth/internal/tokenstore/tokenstore.go

@@ -22,7 +22,7 @@ type storeData struct {
 func New(rootDir string) (*Store, error) {
 	// The store contains tokens that enable a particular user to authenticate.
 	// It's important that the directory can only be read by that user.
-	err := os.MkdirAll(rootDir, 0700)
+	err := os.MkdirAll(rootDir, 0o700)
 	if err != nil {
 		return nil, err
 	}

pkg/filecache/filecache.go

@@ -11,8 +11,10 @@ import (
 	"go.jetpack.io/pkg/cachehash"
 )
 
-var NotFound = errors.New("not found")
-var Expired = errors.New("expired")
+var (
+	NotFound = errors.New("not found")
+	Expired  = errors.New("expired")
+)
 
 type Cache[T any] struct {
 	domain   string
@@ -55,7 +57,7 @@ func (c *Cache[T]) Set(key string, val T, dur time.Duration) error {
 		return errors.WithStack(err)
 	}
 
-	return errors.WithStack(os.WriteFile(c.filename(key), d, 0644))
+	return errors.WithStack(os.WriteFile(c.filename(key), d, 0o644))
 }
 
 // SetWithTime is like Set but it allows the caller to specify the expiration
@@ -66,7 +68,7 @@ func (c *Cache[T]) SetWithTime(key string, val T, t time.Time) error {
 		return errors.WithStack(err)
 	}
 
-	return errors.WithStack(os.WriteFile(c.filename(key), d, 0644))
+	return errors.WithStack(os.WriteFile(c.filename(key), d, 0o644))
 }
 
 // Get retrieves a value from the cache with the given key.
@@ -142,6 +144,6 @@ func IsCacheMiss(err error) bool {
 
 func (c *Cache[T]) filename(key string) string {
 	dir := filepath.Join(c.cacheDir, c.domain)
-	_ = os.MkdirAll(dir, 0755)
+	_ = os.MkdirAll(dir, 0o755)
 	return filepath.Join(dir, cachehash.Slug(key))
 }

pkg/runx/impl/fileutil/fileutil.go

@@ -59,7 +59,7 @@ func EnsureDir(path string) error {
 	if IsDir(path) {
 		return nil
 	}
-	return os.MkdirAll(path, 0700 /* as suggested by xdg spec */)
+	return os.MkdirAll(path, 0o700 /* as suggested by xdg spec */)
 }
 
 func (p Path) EnsureDir() error {
@@ -86,5 +86,5 @@ func WriteFile(path string, data []byte) error {
 		return err
 	}
 	// Write using `renameio` to ensure an atomic write:
-	return renameio.WriteFile(path, data, 0600)
+	return renameio.WriteFile(path, data, 0o600)
 }

pkg/runx/impl/registry/extract.go

@@ -57,10 +57,10 @@ func contentDir(path string) string {
 }
 
 func createSymbolicLink(src, dst, repoName string) error {
-	if err := os.MkdirAll(dst, 0700); err != nil {
+	if err := os.MkdirAll(dst, 0o700); err != nil {
 		return err
 	}
-	if err := os.Chmod(src, 0755); err != nil {
+	if err := os.Chmod(src, 0o755); err != nil {
 		return err
 	}
 	binaryName := filepath.Base(src)

pkg/runx/impl/types/errors.go

@@ -2,6 +2,8 @@ package types
 
 import "errors"
 
-var ErrPackageNotFound = errors.New("package not found")
-var ErrReleaseNotFound = errors.New("release not found")
-var ErrPlatformNotSupported = errors.New("package doesn't support platform")
+var (
+	ErrPackageNotFound      = errors.New("package not found")
+	ErrReleaseNotFound      = errors.New("release not found")
+	ErrPlatformNotSupported = errors.New("package doesn't support platform")
+)

templates/hello-go/main.go

@@ -1,15 +1,15 @@
 package main
 
 import (
-    "fmt"
-    "net/http"
+	"fmt"
+	"net/http"
 )
 
 func main() {
-    http.HandleFunc("/", HelloServer)
-    http.ListenAndServe(":8080", nil)
+	http.HandleFunc("/", HelloServer)
+	http.ListenAndServe(":8080", nil)
 }
 
 func HelloServer(w http.ResponseWriter, r *http.Request) {
-    fmt.Fprintf(w, "Hello, %s!", r.URL.Path[1:])
+	fmt.Fprintf(w, "Hello, %s!", r.URL.Path[1:])
 }

typeid/typeid-go/encoding.go

@@ -7,8 +7,10 @@ import (
 // TODO: Define a standardized binary encoding for typeids in the spec
 // and use that to implement encoding.BinaryMarshaler and encoding.BinaryUnmarshaler
 
-var _ encoding.TextMarshaler = (*TypeID[AnyPrefix])(nil)
-var _ encoding.TextUnmarshaler = (*TypeID[AnyPrefix])(nil)
+var (
+	_ encoding.TextMarshaler   = (*TypeID[AnyPrefix])(nil)
+	_ encoding.TextUnmarshaler = (*TypeID[AnyPrefix])(nil)
+)
 
 // UnmarshalText implements the encoding.TextUnmarshaler interface.
 // It parses a TypeID from a string using the same logic as FromString()

typeid/typeid-go/typeid.go

@@ -42,7 +42,6 @@ func (tid TypeID[P]) String() string {
 // UUIDBytes decodes the TypeID's suffix as a UUID and returns it's bytes
 func (tid TypeID[P]) UUIDBytes() []byte {
 	b, err := base32.Decode(tid.Suffix())
-
 	// Decode only fails if the suffix cannot be decoded for one of two reasons:
 	// 1. The suffix is not 26 characters long
 	// 2. The suffix contains characters that are not in the base32 alphabet