Keep one of the duplicated secrets

There is really no problem with duplicated secrets: these exist, and will be shared
by the ingresses that refer to them. The existing code excluded a secret as soon as
it was referenced by more one than place, but we should really just de-duplicate
the given list based on namespace/name.

Author: ankon

pkg/kubelego/configure.go

@@ -26,28 +26,26 @@ func (kl *KubeLego) TlsIgnoreDuplicatedSecrets(tlsSlice []kubelego.Tls) []kubele
 
 	output := []kubelego.Tls{}
 	for key, slice := range tlsBySecret {
-		if len(slice) == 1 {
-			output = append(output, slice...)
-			continue
-		}
-
-		texts := []string{}
-		for _, elem := range slice {
-			texts = append(
-				texts,
-				fmt.Sprintf(
-					"ingress %s/%s (hosts: %s)",
-					elem.IngressMetadata().Namespace,
-					elem.IngressMetadata().Name,
-					strings.Join(elem.Hosts(), ", "),
-				),
+		output = append(output, slice[0])
+		if len(slice) > 1 {
+			texts := []string{}
+			for _, elem := range slice[1:] {
+				texts = append(
+					texts,
+					fmt.Sprintf(
+						"ingress %s/%s (hosts: %s)",
+						elem.IngressMetadata().Namespace,
+						elem.IngressMetadata().Name,
+						strings.Join(elem.Hosts(), ", "),
+					),
+				)
+			}
+			kl.Log().Warnf(
+				"the secret %s is used multiple times. These linked TLS ingress elements where ignored: %s",
+				key,
+				strings.Join(texts, ", "),
 			)
 		}
-		kl.Log().Warnf(
-			"the secret %s is used multiple times. These linked TLS ingress elements where ignored: %s",
-			key,
-			strings.Join(texts, ", "),
-		)
 	}
 
 	return output

pkg/kubelego/configure_test.go

@@ -72,5 +72,5 @@ func TestKubeLego_TlsIgnoreDuplicatedSecrets(t *testing.T) {
 	k := New("test")
 	input := getTlsExample()
 	output := k.TlsIgnoreDuplicatedSecrets(input)
-	assert.EqualValues(t, 2, len(output))
+	assert.EqualValues(t, 3, len(output))
 }