Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Commit 2f44ecc

Browse files
committed
Output converging machine names
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
1 parent 73a40e3 commit 2f44ecc

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

pkg/tarmak/cluster/configuration.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111

1212
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1313

14+
"github.com/jetstack/tarmak/pkg/apis/wing/common"
1415
wingv1alpha1 "github.com/jetstack/tarmak/pkg/apis/wing/v1alpha1"
1516
)
1617

@@ -145,7 +146,10 @@ func (c *Cluster) WaitForConvergance() error {
145146

146147
var convergingMachines []string
147148
for _, m := range mList.Items {
148-
convergingMachines = append(convergingMachines, m.Name)
149+
if m.Status == nil || m.Status.Converge == nil ||
150+
m.Status.Converge.State != common.MachineManifestStateConverged {
151+
convergingMachines = append(convergingMachines, m.Name)
152+
}
149153
}
150154

151155
reps := d.Status.Replicas

pkg/wing/controller/machinedeployment/controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ func (c *Controller) createControlledMachineSet(md *v1alpha1.MachineDeployment)
132132
maxReplicas = *md.Spec.MaxReplicas
133133
}
134134

135-
c.log.Infof("Creating MachineSet for MachineDeployment %s\n", md.Name)
135+
c.log.Infof("Creating MachineSet from MachineDeployment %s\n", md.Name)
136136
ms := &v1alpha1.MachineSet{
137137
ObjectMeta: metav1.ObjectMeta{
138138
Name: md.Name,

pkg/wing/controller/machineset/controller.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ func NewController(queue workqueue.RateLimitingInterface, indexer cache.Indexer,
3333
informer: informer,
3434
indexer: indexer,
3535
queue: queue,
36-
log: logrus.NewEntry(logrus.New()).WithField("tier", "controller"),
36+
log: logrus.NewEntry(logrus.New()).WithField("tier", "MachineSet-controller"),
3737
client: client,
3838
}
3939
}
@@ -80,7 +80,6 @@ func (c *Controller) syncToStdout(key string) error {
8080

8181
// machineset doesn't exist for this machine
8282
if !found {
83-
c.log.Warnf("did not find machineset for machine %s", m.Name)
8483
return nil
8584
}
8685

0 commit comments

Comments
 (0)