Normalize Salesforce connection errors to appropriate HTTP status codes#1846
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves API error handling for known Salesforce connection/auth failures by mapping them to deterministic 4xx HTTP status codes (instead of sometimes passing through Salesforce’s upstream 5xx statuses), reducing misleading “server error” responses and avoiding false 5xx alerting.
Changes:
- Detects known Salesforce connection/auth error messages and normalizes the HTTP status to 401 (auth/connection) or 403 (“REST API not enabled”).
- Reuses the same detection for (a) org invalidation side-effects and (b) deferred-mode error body enrichment, avoiding duplicated condition checks.
- Adds Vitest coverage to ensure both
UserFacingErrorand generic/unwrapped errors normalize to 4xx as intended.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/api/src/app/utils/response.handlers.ts | Adds message-based detection for known Salesforce connection errors and normalizes response status to 401/403 across both typed and generic error paths. |
| apps/api/src/app/utils/tests/response.handlers.spec.ts | Adds tests validating normalization behavior and that org invalidation side-effects still occur for expired-token scenarios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve error handling for Salesforce connection issues by normalizing specific errors to their corresponding HTTP status codes. This change prevents misleading 500 errors from being sent to clients for authentication failures and ensures that users are prompted to reconnect when necessary.