Enable all 8 layers and update mapping row layout#332
Open
MarqueIV wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple layout and firmware change to fully enable eight layers
Firmware Changes
NLAYERSfrom 4 to 8Web config changes
Live Demo: https://markdonohoe.com/remapper
Note:
NLAYERSabove seems to be used for 'safety' logic regarding layer-switching mappings for cases where values on target layers aren't properly set in a configuration. However both the UI and the CLI tools properly create configurations that avoid this caveat, thus seemingly making this check seem redundant/unnecessary. However I am not sure if there are other ways to load configurations where such correctness isn't guaranteed, so to keep the firmware resilient, it makes sense to leave the check in place, hence updating the value here.Testing
I have been running this with the latest firmware for a few months now with very complex configs and have not had any issues so far. Overall it appears to be quite stable.
Screenshots