fix: use measured layout dimensions instead of Dimensions.get('window')#186
Open
hiiamhip wants to merge 1 commit into
Open
fix: use measured layout dimensions instead of Dimensions.get('window')#186hiiamhip wants to merge 1 commit into
hiiamhip wants to merge 1 commit into
Conversation
hiiamhip
force-pushed
the
fix/use-measured-layout-instead-of-dimensions
branch
from
4ceacfd to
82c7a1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_onLayout currently ignores its event parameter and reads from
Dimensions.get('window'), which returns the full screen including
system UI (navigation bar, status bar, etc.).
On devices where the component does not occupy the entire screen
e.g. Android car head units with a persistent left nav bar,
or tablets in split-screen mode - the measured width is larger
than the actual viewport. This breaks pagingEnabled FlatList: