Log audit errors when fail_upon_any_scanner_error is disabled (#1352)

* Log underlying scanner errors when partial results are allowed.

When fail_upon_any_scanner_error is disabled, frogbot continued without failing but only logged a generic warning, hiding the audit error that support needs to diagnose failures.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Use %v when logging scanner errors in partial-results path.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Avoid logging fix errors twice in partial-results path.

The fix-vulnerabilities call site already embedded err in messageForLog;
CreateErrorIfFailUponScannerErrorEnabled now appends the error separately.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: Jordanh1996

scanrepository/scanrepository.go

@@ -248,7 +248,7 @@ func (sr *ScanRepositoryCmd) fixVulnerablePackages(repository *utils.Repository,
 		}
 	}
 	if err != nil {
-		return utils.CreateErrorIfFailUponScannerErrorEnabled(repository.GeneralConfig.FailUponAnyScannerError, fmt.Sprintf("failed to fix vulnerable dependencies: %s", err.Error()), err)
+		return utils.CreateErrorIfFailUponScannerErrorEnabled(repository.GeneralConfig.FailUponAnyScannerError, "failed to fix vulnerable dependencies", err)
 	}
 	return nil
 }

utils/utils.go

@@ -466,7 +466,7 @@ func isUrlAccessible(url string) bool {
 // If not - instead of returning an error we log the error and continue as if we didn't have an error
 func CreateErrorIfFailUponScannerErrorEnabled(fail bool, messageForLog string, err error) error {
 	if !fail {
-		log.Warn(messageForLog)
+		log.Warn(fmt.Sprintf("%s: %v", messageForLog, err))
 		return nil
 	}
 	return err