Skip to content

Switch Archive Download to Git Clone in scan-pr#1361

Closed
eranturgeman wants to merge 3 commits into
jfrog:v3_erfrom
eranturgeman:change-to-git-clone-in-scan-pr
Closed

Switch Archive Download to Git Clone in scan-pr#1361
eranturgeman wants to merge 3 commits into
jfrog:v3_erfrom
eranturgeman:change-to-git-clone-in-scan-pr

Conversation

@eranturgeman

Copy link
Copy Markdown
Collaborator
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

A customer had an issue where the scan failed in a Gradle project scan, because the downloaded repo (archive download) did not contain .git dir.
Gradle evaluates all build.gradle scripts during its configuration phase, before reaching generateDepTrees. One of the scripts required a .git dir which does not exist in an archive download.
The fix is simple - switching the usage of archive download with git clone.
This is a bit slower but fixes the issue easily.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@eranturgeman eranturgeman changed the base branch from master to v3_er June 28, 2026 06:49
@eranturgeman eranturgeman added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jun 28, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant