Switch Archive Download to Git Clone in scan-pr#1361
Closed
eranturgeman wants to merge 3 commits into
Closed
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A customer had an issue where the scan failed in a Gradle project scan, because the downloaded repo (archive download) did not contain .git dir.
Gradle evaluates all build.gradle scripts during its configuration phase, before reaching generateDepTrees. One of the scripts required a .git dir which does not exist in an archive download.
The fix is simple - switching the usage of archive download with git clone.
This is a bit slower but fixes the issue easily.