Skip to content

Replace optional chaining syntax for Node.js compatibility #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhanurp wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Replace optional chaining syntax for Node.js compatibility #583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions jfrog-tasks-utils/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,15 @@ function syncRequestWithRetry(method, url, options = {}, maxRetries = 3, retryDe
try {
const response = syncRequest(method, url, options);
// Retry on 5xx server errors
if (response?.statusCode >= 500 && response?.statusCode < 600) {
console.warn(`Attempt ${attempt}/${maxRetries}: Server error ${response?.statusCode} for ${url}`);
const statusCode = response && response.statusCode;
if (statusCode >= 500 && statusCode < 600) {
console.warn(`Attempt ${attempt}/${maxRetries}: Server error ${statusCode} for ${url}`);
lastResponse = response;
} else {
return response;
}
} catch (err) {
console.warn(`Attempt ${attempt}/${maxRetries}: Request failed for ${url} - ${err?.message}`);
console.warn(`Attempt ${attempt}/${maxRetries}: Request failed for ${url} - ${err && err.message}`);
errorToThrow = err;
}

Expand Down Expand Up @@ -68,9 +69,9 @@ function isCliBinaryAvailable(version) {
try {
console.log('Verifying CLI binary availability at: ' + binaryUrl);
const res = syncRequestWithRetry('HEAD', binaryUrl, { timeout: 5000 });
return res?.statusCode === 200;
return res && res.statusCode === 200;
} catch (err) {
console.warn('Failed to verify CLI binary availability: ' + err?.message);
console.warn('Failed to verify CLI binary availability: ' + (err && err.message));
return false;
}
}
Expand All @@ -91,7 +92,7 @@ function fetchLatestCliVersion() {
});
if (res.statusCode === 200) {
const releases = JSON.parse(res.getBody('utf8'));
console.log('Fetched ' + releases?.length ?? 0 + ' JFrog CLI releases');
console.log('Fetched ' + (releases && releases.length ? releases.length : 0) + ' JFrog CLI releases');

if (!releases || releases.length === 0) {
console.warn('No JFrog CLI releases found, using fallback: ' + fallbackCliVersion);
Expand All @@ -100,7 +101,7 @@ function fetchLatestCliVersion() {

// Try each release until we find one with an available binary
for (const release of releases) {
const version = release?.name;
const version = release && release.name;
console.log('Checking CLI version: ' + version);

if (version && isCliBinaryAvailable(version)) {
Expand All @@ -114,7 +115,7 @@ function fetchLatestCliVersion() {
}
console.warn('Unexpected status code: ' + res.statusCode + ', using fallback version: ' + fallbackCliVersion);
} catch (err) {
console.warn('Failed to fetch JFrog CLI releases, due to error: ' + err?.message + ', using fallback: ' + fallbackCliVersion);
console.warn('Failed to fetch JFrog CLI releases, due to error: ' + (err && err.message) + ', using fallback: ' + fallbackCliVersion);
}
return fallbackCliVersion;
}
Expand Down
Loading