Improve attachment verification failure messages

Author: mnsboev

evidence/verify/verifiers/attachment_verifier.go

@@ -14,7 +14,9 @@ import (
 )
 
 const (
-	attachmentMetadataNotFoundReason    = "attachment metadata not found in GraphQL response"
+	attachmentMetadataNotFoundReason    = "attachment not found in Evidence"
+	attachmentArtifactNotFoundReason    = "attachment not found in Artifactory"
+	checksumMismatchReason              = "checksum mismatch"
 	attachmentMetadataUnavailableReason = "unable to get attachment metadata from GraphQL (query without attachments)"
 	attachmentVerificationFailedReason  = "attachment failed verification"
 )
@@ -76,7 +78,7 @@ func (v *attachmentVerifier) verify(evidence *model.SearchEvidenceEdge, result *
 		fileInfo, fileInfoErr := v.artifactoryClient.FileInfo(actualAttachment.DownloadPath)
 		if fileInfoErr != nil && isAttachmentNotFoundError(fileInfoErr) {
 			verification.VerificationStatus = model.Failed
-			verification.FailureReason = "file not found"
+			verification.FailureReason = attachmentArtifactNotFoundReason
 			verifications = append(verifications, verification)
 			hasFailures = true
 			continue
@@ -89,7 +91,7 @@ func (v *attachmentVerifier) verify(evidence *model.SearchEvidenceEdge, result *
 		verification.ActualSha256 = fileInfo.Checksums.Sha256
 		if verification.ActualSha256 != expected.Sha256 {
 			verification.VerificationStatus = model.Failed
-			verification.FailureReason = "checksum mismatch"
+			verification.FailureReason = checksumMismatchReason
 			hasFailures = true
 		}
 		verifications = append(verifications, verification)

evidence/verify/verifiers/attachment_verifier_test.go

@@ -232,7 +232,7 @@ func TestAttachmentVerifier_Verify_FileNotFound404(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Equal(t, model.Failed, result.VerificationResult.AttachmentsVerificationStatus)
 	if assert.Len(t, result.AttachmentsVerification, 1) {
-		assert.Equal(t, "file not found", result.AttachmentsVerification[0].FailureReason)
+		assert.Equal(t, attachmentArtifactNotFoundReason, result.AttachmentsVerification[0].FailureReason)
 		assert.Equal(t, model.Failed, result.AttachmentsVerification[0].VerificationStatus)
 	}
 }

evidence/verify/verifiers/evidence_verifier_test.go

@@ -375,7 +375,7 @@ func TestVerify_AttachmentsVerificationFailsWhenMetadataMissing(t *testing.T) {
 	verification := (*result.EvidenceVerifications)[0]
 	assert.Equal(t, model.Failed, verification.VerificationResult.AttachmentsVerificationStatus)
 	assert.Equal(t, "attachment failed verification", verification.VerificationResult.FailureReason)
-	assert.Equal(t, "attachment metadata not found in GraphQL response", verification.AttachmentsVerification[0].FailureReason)
+	assert.Equal(t, attachmentMetadataNotFoundReason, verification.AttachmentsVerification[0].FailureReason)
 }
 
 func TestVerify_AttachmentsVerificationReturnsErrorWhenMetadataUnavailableViaFallback(t *testing.T) {