Skip to content

Commit 0131a67

Browse files
authored
JGC-499 - Remove concurrency from reusable test suites (#3549)
When invoked via workflow_call, each suite's `concurrency` group resolves using the caller's context (github.workflow = "Build Gate"), so all suites and the parent run share one identical group. With cancel-in-progress: true they cancelled each other before starting, leaving only frogbot (which has no concurrency block) to run and making build-gate-success fail on cancelled needs. The orchestrator's own concurrency already supersedes older runs per PR/branch, so the per-suite blocks are removed.
1 parent 4a4cb78 commit 0131a67

25 files changed

Lines changed: 0 additions & 105 deletions

.github/workflows/accessTests.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ on:
1414
required: false
1515
default: ""
1616

17-
# Ensures that only the latest commit is running for each PR at a time.
18-
concurrency:
19-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }}
20-
cancel-in-progress: true
2117
permissions:
2218
id-token: write
2319
contents: read

.github/workflows/artifactoryTests.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ on:
1414
required: false
1515
default: ""
1616

17-
# Ensures that only the latest commit is running for each PR at a time.
18-
concurrency:
19-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }}
20-
cancel-in-progress: true
2117
jobs:
2218
Artifactory-Tests:
2319
name: ${{ matrix.suite }} ${{ matrix.os.name }}

.github/workflows/conanTests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ on:
1414
required: false
1515
default: ""
1616

17-
concurrency:
18-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }}
19-
cancel-in-progress: true
2017
jobs:
2118
Conan-Tests:
2219
name: Conan tests (${{ matrix.os.name }})

.github/workflows/distributionTests.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@ on:
33
workflow_call:
44
workflow_dispatch:
55

6-
# Ensures that only the latest commit is running for each PR at a time.
7-
concurrency:
8-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }}
9-
cancel-in-progress: true
106
jobs:
117
Distribution-Tests:
128
name: Distribution tests (${{ matrix.os }})

.github/workflows/dockerTests.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@ on:
33
workflow_call:
44
workflow_dispatch:
55

6-
# Ensures that only the latest commit is running for each PR at a time.
7-
concurrency:
8-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }}
9-
cancel-in-progress: true
106
jobs:
117
Docker-tests:
128
name: Docker tests (${{ matrix.os.name }}, containerd-snapshotter=${{ !matrix.disable-containerd-snapshotter }})

.github/workflows/evidenceTests.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@ on:
33
workflow_call:
44
workflow_dispatch:
55

6-
# Ensures that only the latest commit is running for each PR at a time.
7-
concurrency:
8-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }}
9-
cancel-in-progress: true
106
jobs:
117
Evidence-Tests:
128
name: Evidence tests (${{ matrix.os }})
@@ -44,4 +40,3 @@ jobs:
4440

4541
- name: Run Evidence tests
4642
run: go test -v github.com/jfrog/jfrog-cli --timeout 0 --test.evidence --jfrog.url=${{ secrets.EPLUS_PLATFORM_URL }} --jfrog.adminToken=${{ secrets.EPLUS_ADMIN_TOKEN }} --jfrog.evidenceToken=${{ secrets.EVIDENCE_USER_TOKEN }} --jfrog.projectKey=${{ secrets.EVIDENCE_PROJECT_KEY }} --jfrog.projectToken=${{ secrets.EVIDENCE_PROJECT_TOKEN }} --ci.runId=${{ runner.os }}-evidence
47-

.github/workflows/ghostFrogTests.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@ on:
33
workflow_call:
44
workflow_dispatch:
55

6-
# Ensures that only the latest commit is running for each PR at a time.
7-
concurrency:
8-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }}
9-
cancel-in-progress: true
106
jobs:
117
Ghost-Frog-Tests:
128
name: Ghost Frog tests (${{ matrix.os.name }})

.github/workflows/goTests.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@ on:
66
workflow_call:
77
workflow_dispatch:
88

9-
# Ensures that only the latest commit is running for each PR at a time.
10-
concurrency:
11-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }}
12-
cancel-in-progress: true
139
jobs:
1410
GO-tests:
1511
# Go modules doesn't allow passing credentials to a private registry using an HTTP URL. Therefore, the Go tests run against a remote Artifactory server.

.github/workflows/gradleTests.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ on:
1414
required: false
1515
default: ""
1616

17-
# Ensures that only the latest commit is running for each PR at a time.
18-
concurrency:
19-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }}
20-
cancel-in-progress: true
2117
jobs:
2218
Gradle-Tests:
2319
name: ${{ matrix.os.name }}-gradle-${{ matrix.gradle-version }}

.github/workflows/helmTests.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ on:
1414
required: false
1515
default: ""
1616

17-
# Ensures that only the latest commit is running for each PR at a time.
18-
concurrency:
19-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }}
20-
cancel-in-progress: true
2117
permissions:
2218
id-token: write
2319
contents: read
@@ -102,4 +98,3 @@ jobs:
10298
go test -v github.com/jfrog/jfrog-cli --timeout 0 --test.helm
10399
--jfrog.url=${{ env.JFROG_TESTS_URL || 'http://127.0.0.1:8082' }}
104100
--jfrog.adminToken=${{ env.JFROG_TESTS_LOCAL_ACCESS_TOKEN }}
105-

0 commit comments

Comments
 (0)