fix(searchutil): nil-guard ResultItem.ToArtifact against nil receiver#1339
Open
SAY-5 wants to merge 1 commit into
Open
fix(searchutil): nil-guard ResultItem.ToArtifact against nil receiver#1339SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Multi-arch container push callers in jfrog-cli-artifactory (OCI buildinfo.createPushBuildProperties) reach ToArtifact on a nil *ResultItem when the manifest-digest SHA lookup misses in Artifactory. The direct item.Name deref crashed the build with 'invalid memory address or nil pointer dereference' and took the entire jenkins build down. Return a zero-value buildinfo.Artifact when item is nil so callers see an empty record and can handle it as 'no matching artifact' upstream, rather than fatally panicking the process. Refs jfrog/jfrog-cli issue 3450. Signed-off-by: SAY-5 <say.apm35@gmail.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the downstream crash reported at jfrog/jfrog-cli#3450.
Multi-arch container push callers in jfrog-cli-artifactory (OCI
buildinfo.createPushBuildProperties) reachToArtifacton a nil*ResultItemwhen the manifest-digest SHA lookup misses in Artifactory. The directitem.Namederef crashes the build with:…and takes the Jenkins build down.
Fix
Return a zero-value
buildinfo.Artifactwhenitemis nil so callers see an empty record and can treat it as "no matching artifact" upstream, rather than fatally panicking the process.go build ./artifactory/services/utils/...clean.