Skip to content

fix(searchutil): nil-guard ResultItem.ToArtifact against nil receiver #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(searchutil): nil-guard ResultItem.ToArtifact against nil receiver #1339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions artifactory/services/utils/searchutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,16 @@ func (item ResultItem) GetItemRelativeLocation() string {
}

func (item *ResultItem) ToArtifact() buildinfo.Artifact {
// Multi-arch container push callers (jfrog-cli-artifactory OCI
// buildinfo.createPushBuildProperties) reach ToArtifact on the
// zero-value element of a nil ResultItem pointer when the
// manifest-digest SHA lookup misses in Artifactory. The previous
// code then SIGSEGV'd on item.Name and took the whole build down.
// Return a zero Artifact instead so the caller sees an empty
// result and can handle it as "no matching artifact" upstream.
if item == nil {
return buildinfo.Artifact{}
}
return buildinfo.Artifact{
Name: item.Name,
Checksum: buildinfo.Checksum{
Expand Down
Loading