Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an LRU cache and uses it to cache regex patterns for the
matchandsearchfunction extensions.Previously we relied on the
remodule's internal cache. But since we now check patterns against I-Regexp (if it's installed) and map patterns from I-Regexp to Python re compatible patterns, we need our own cache.Both
jsonpath.function_extensions.Matchandjsonpath.function_extensions.Searchnow also accept additional constructor arguments:cache_capacity: The size of the regular expression cache.debug: WhenTrue, raise an exception when regex pattern compilation fails. The default - as required by RFC 9535 - isFalse, which silently ignores bad patterns.thread_safe: WhenTrue, use aThreadSafeLRUCacheinstead of an instance ofLRUCache.