Disable non-standard functions in strict mode#110
Merged
Conversation
|
Not sure if this is right, the rfc says we can register methods. |
Owner
Author
|
Yeah, there's nothing stopping users registering non-standard functions with their own Anything other than those two preconfigured environments, I expect users to do something like this. from jsonpath import JSONPathEnvironment
from jsonpath.function_extensions import StartsWith
class MyJSONPathEnvironment(JSONPathEnvironment):
def __init__(self) -> None:
super().__init__(strict=True)
def setup_function_extensions(self) -> None:
super().setup_function_extensions()
self.function_extensions["startswith"] = StartsWith()
jsonpath = MyJSONPathEnvironment()
query = jsonpath.compile("...")Do you think this is a reasonable approach? I'll defiantly update the docs and to make this clearer. |
|
I think maybe just make sure the predefined one can not be overrided |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
JSONPathEnvironment.setup_function_extensions()to skip registering non-standard functions whenstrictisTrue.Standard functions are those defined by RFC 9535,
count,length,match,searchandvalue.Non-standard, built-in function are:
isinstance(aliasis)typeof(aliastype)startswithkeys