Skip to content

Fix Sass deprecation warnings related to if-functions. #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mickverm wants to merge 3 commits into from
+36 −26
Closed

Fix Sass deprecation warnings related to if-functions. #4028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66d1b4b
chore(deps-dev): bump sass from 1.94.2 to 1.97.1
mickverm Jan 2, 2026
f24f4dc
chore: fix if-function deprecation warnings.
mickverm Jan 2, 2026
72f1239
chore: update CHANGELOG.md
mickverm Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Bulma Changelog

## 1.0.5

### Bug Fixes

- Fix #4026: migrate code to avoid Sass 1.95 deprecation warnings of if-functions.

## 1.0.4

### New Features
Expand Down
9 changes: 5 additions & 4 deletions docs/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
"devDependencies": {
"@shopify/prettier-plugin-liquid": "^1.10.0",
"prettier": "^3.7.4",
"sass": "^1.94.2"
"sass": "^1.97.1"
}
}
27 changes: 15 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"postcss-cli": "^11.0.1",
"prettier": "^3.7.4",
"rimraf": "^6.1.2",
"sass": "^1.94.2"
"sass": "^1.97.1"
},
"scripts": {
"build-bulma": "sass --style=expanded --source-map bulma.scss css/bulma.css",
Expand Down
2 changes: 1 addition & 1 deletion sass/helpers/typography.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
@each $size in dv.$sizes {
$i: list.index(dv.$sizes, $size);

.#{iv.$class-prefix}#{iv.$helpers-prefix}size-#{$i}#{if($target == "", "", "-" + $target)} {
.#{iv.$class-prefix}#{iv.$helpers-prefix}size-#{$i}#{if(sass($target == ""): ""; else: "-" + $target)} {
font-size: $size !important;
}
}
Expand Down
6 changes: 3 additions & 3 deletions sass/utilities/functions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,12 +286,12 @@
"9": 9,
);

@for $i from if($minus, 2, 1) through string.length($value) {
@for $i from if(sass($minus): 2; else: 1) through string.length($value) {
$character: string.slice($value, $i, $i);

@if not(list.index(map.keys($numbers), $character) or $character == ".") {
@return to-length(
if($minus, -$result, $result),
if(sass($minus): -$result; else: $result),
string.slice($value, $i)
);
}
Expand All @@ -306,5 +306,5 @@
}
}

@return if($minus, -$result, $result);
@return if(sass($minus): -$result; else: $result);
}
8 changes: 4 additions & 4 deletions sass/utilities/mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,8 @@
}

@mixin ltr-property($property, $spacing, $right: true) {
$normal: if($right, "right", "left");
$opposite: if($right, "left", "right");
$normal: if(sass($right): "right"; else: "left");
$opposite: if(sass($right): "left"; else: "right");

@if iv.$rtl {
#{$property}-#{$opposite}: $spacing;
Expand All @@ -420,8 +420,8 @@
}

@mixin ltr-position($spacing, $right: true) {
$normal: if($right, "right", "left");
$opposite: if($right, "left", "right");
$normal: if(sass($right): "right"; else: "left");
$opposite: if(sass($right): "left"; else: "right");

@if iv.$rtl {
#{$opposite}: $spacing;
Expand Down