fix(web): show custom 500 page on CMS errors instead of blank page#44
Merged
Conversation
The page data was fetched inside CollectionLayout, i.e. while the SSR response was already streaming. A CMS error thrown at that point could no longer switch Astro to the custom 500 page, so visitors got a blank page with HTTP 200. Move the getPageData call up into the page route frontmatter (before the response starts streaming) and pass the result down as a prop, so a CMS error surfaces as the custom 500 page with HTTP 500. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YF1wMNs82v8QuQDSW17xG8
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page data was fetched inside CollectionLayout, i.e. while the SSR
response was already streaming. A CMS error thrown at that point could no
longer switch Astro to the custom 500 page, so visitors got a blank page
with HTTP 200.
Move the getPageData call up into the page route frontmatter (before the
response starts streaming) and pass the result down as a prop, so a CMS
error surfaces as the custom 500 page with HTTP 500.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01YF1wMNs82v8QuQDSW17xG8