Skip to content

Commit a88e9cf

Browse files
committed
Use parameters to objects directly, no need to cache them at the top
1 parent 170b04e commit a88e9cf

3 files changed

Lines changed: 7 additions & 12 deletions

File tree

src/Diff.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
var SourceDiff = SourceDiff || {};
22

33
SourceDiff.Diff = function(ignoreLeadingWS) {
4-
var _ignoreLeadingWS = ignoreLeadingWS;
5-
64
var trimTrailingWhiteSpace = function(str) {
75
if (str) {
86
return str.replace(/\s\s*$/, '');
@@ -11,7 +9,7 @@ SourceDiff.Diff = function(ignoreLeadingWS) {
119
};
1210

1311
var checkTrimLeadingWhiteSpace = function(str) {
14-
if (str && _ignoreLeadingWS) {
12+
if (str && ignoreLeadingWS) {
1513
return str.replace(/^\s\s*/, '');
1614
}
1715
return str;

src/DiffFormatter.js

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
var SourceDiff = SourceDiff || {};
22

33
SourceDiff.DiffFormatter = function(diff) {
4-
var _diff = diff;
5-
64
var formattedDiff = function(originalText, editedText) {
7-
var results = _diff.diff(originalText, editedText);
5+
var results = diff.diff(originalText, editedText);
86

97
var lines = lineUpText(originalText, editedText, results);
108

@@ -24,11 +22,11 @@ SourceDiff.DiffFormatter = function(diff) {
2422
};
2523

2624
var lineUpText = function(originalText, editedText, results) {
27-
var originalLines = _diff.split(originalText);
28-
var editedLines = _diff.split(editedText);
25+
var originalLines = diff.split(originalText);
26+
var editedLines = diff.split(editedText);
2927

30-
_diff.padBlankLines(originalLines);
31-
_diff.padBlankLines(editedLines);
28+
diff.padBlankLines(originalLines);
29+
diff.padBlankLines(editedLines);
3230

3331
results.paddingLeft = new SourceDiff.EditSet();
3432
results.paddingRight = new SourceDiff.EditSet();
@@ -68,7 +66,7 @@ SourceDiff.DiffFormatter = function(diff) {
6866

6967
for (var i = 0; i < originalLines.length && i < editedLines.length; i++) {
7068
if (results.modifiedLeft.contains(i) || results.modifiedRight.contains(i)) {
71-
var lineDiff = _diff.lineDiff(originalLines[i], editedLines[i]);
69+
var lineDiff = diff.lineDiff(originalLines[i], editedLines[i]);
7270
lineDiff.cleanUp();
7371

7472
lineDiffs.addValue(i, lineDiff);

src/LineFormatter.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
var SourceDiff = SourceDiff || {};
22

33
SourceDiff.LineFormatter = function(results, lineDiffs) {
4-
54
var formatLeftText = function (text1Lines) {
65
var deletedText = '';
76

0 commit comments

Comments
 (0)