use src module#118
Conversation
|
I may add rocm builds in the future, but only as a vendor release(the rocm patches I found are forks of the original code/break cuda[cuda is the used backend, but the logic is replaced with rocm]) |
|
I tested it manually for macOS & linux(cuda). compiling works for all OSes. it can be assumed that the vendor feature works on every operating system & building from source too |
|
Thank you for this PR. I really appreciate your contribution, but I don’t think we should merge it as-is. I’m currently working on the system feature (#108), which already makes use of the pre-compiled libraries you uploaded in Release v4.6.0 · frederik-uni/ctranslate2-src. For example, on macOS I can pass all tests on the system branch with the following commands: And on Linux, after copying So instead of merging this PR, I think the better approach would be to provide pre-compiled libraries (using your Would that work for you? |
having a src module did not work as expected, so I opted to use a helper crate. I didnt use all the features I implemented.
features disabled are
sharednot testedcrt-dynamicon static buildsexport-vendorCompiling works on macOS, linux, windows. I also tested if vendor & using it works on macOS. I will test the vendor feature on linux tomorrow, but I expect it to work