fix: preserve trailing newlines in unchanged --set literals#770
Open
fuleinist wants to merge 1 commit into
Open
fix: preserve trailing newlines in unchanged --set literals#770fuleinist wants to merge 1 commit into
fuleinist wants to merge 1 commit into
Conversation
Fixes jkroepke#752 Command substitution $( ) strips trailing newlines, so a --set literal ending in a newline always fails the string-comparison equality check and triggers unnecessary comma escaping on the output. Add a length check via printf+wc-c so unchanged literals (including those that only differ by a stripped trailing newline) skip escaping.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 87.00% 87.00%
=======================================
Files 22 22
Lines 862 862
=======================================
Hits 750 750
Misses 112 112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #752
Problem: Command substitution $( ) strips trailing newlines. When a --set literal ends with a newline (common with ArgoCD multi-line parameters), the decrypted value (same plain text, newline stripped) fails the equality check and triggers unnecessary comma escaping on output.
Fix: Add a length check via printf+wc-c so unchanged literals — including those that only differ by a stripped trailing newline — skip the sed escaping pass. Also add an explanatory comment.