Skip to content

fix: replace deprecated errors='ignore' with explicit try/except #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yasumorishima wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: replace deprecated errors='ignore' with explicit try/except #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e5145a
fix: replace deprecated errors='ignore' in pd.to_numeric with try/except
yasumorishima Feb 4, 2026
8f83173
fix: replace deprecated errors='ignore' in pd.to_datetime with try/ex…
yasumorishima Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions pybaseball/datahelpers/postprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ def try_parse_dataframe(

if parse_numerics:
data_copy = coalesce_nulls(data_copy, null_replacement)
data_copy = data_copy.apply(
pd.to_numeric,
errors='ignore',
downcast='signed'
).convert_dtypes(convert_string=False)
for col in data_copy.columns:
try:
data_copy[col] = pd.to_numeric(data_copy[col], downcast='signed')
except (ValueError, TypeError):
pass
data_copy = data_copy.convert_dtypes(convert_string=False)

string_columns = [
dtype_tuple[0] for dtype_tuple in data_copy.dtypes.items() if str(dtype_tuple[1]) in ["object", "string"]
Expand Down
5 changes: 4 additions & 1 deletion tests/pybaseball/test_statcast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ def _single_game_raw(get_data_file_contents: Callable[[str], str]) -> str:
@pytest.fixture(name="single_game")
def _single_game(get_data_file_dataframe: GetDataFrameCallable) -> pd.DataFrame:
data = get_data_file_dataframe('single_game_request.csv', parse_dates=[2])
data[data.columns[2]].apply(pd.to_datetime, errors='ignore', format=DATE_FORMAT)
try:
data[data.columns[2]] = pd.to_datetime(data[data.columns[2]], format=DATE_FORMAT)
except (ValueError, TypeError):
pass
return data


Expand Down