Skip to content

Commit 2d9abc4

Browse files
feat(ui): add aria-labels to workshop header icon buttons
Adds descriptive `aria-label` and `title` attributes to the three icon-only buttons (documentation, notifications, user profile) in the WorkshopTakeover header to improve accessibility and usability. Co-authored-by: jmbish04 <26469722+jmbish04@users.noreply.github.com>
1 parent e425896 commit 2d9abc4

2 files changed

Lines changed: 18 additions & 3 deletions

File tree

.Jules/palette.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
## 2025-01-20 - Icon-Only Navigation Buttons Missing Context
2+
**Learning:** Found several top-level navigation action buttons (like documentation, notifications, user profile) that relied solely on generic icons (`FileText`, `Bell`, empty div for avatar) without any accessible labels or tooltips. This is a common pattern in the app's components, causing screen readers to read nothing useful and sighted users to have to guess the action, especially for less standard icons.
3+
**Action:** Ensure that all icon-only buttons globally implement both `aria-label` for screen reader accessibility and `title` attributes for sighted user tooltips, particularly in global navigation headers.

src/frontend/src/components/workshop/WorkshopTakeover.tsx

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,26 @@ export function WorkshopTakeover() {
4141
Create Agent
4242
</button>
4343
<div className="flex items-center gap-2 border-l border-zinc-200 dark:border-zinc-800 pl-4 ml-2">
44-
<button className="flex items-center justify-center rounded-full w-9 h-9 text-zinc-500 hover:bg-zinc-100 dark:hover:bg-zinc-800 dark:hover:text-zinc-50 transition-colors">
44+
<button
45+
className="flex items-center justify-center rounded-full w-9 h-9 text-zinc-500 hover:bg-zinc-100 dark:hover:bg-zinc-800 dark:hover:text-zinc-50 transition-colors"
46+
aria-label="View documentation"
47+
title="View documentation"
48+
>
4549
<FileText className="w-5 h-5" />
4650
</button>
47-
<button className="relative flex items-center justify-center rounded-full w-9 h-9 text-zinc-500 hover:bg-zinc-100 dark:hover:bg-zinc-800 dark:hover:text-zinc-50 transition-colors">
51+
<button
52+
className="relative flex items-center justify-center rounded-full w-9 h-9 text-zinc-500 hover:bg-zinc-100 dark:hover:bg-zinc-800 dark:hover:text-zinc-50 transition-colors"
53+
aria-label="View notifications"
54+
title="View notifications"
55+
>
4856
<Bell className="w-5 h-5" />
4957
<span className="absolute top-1 right-1 block w-2 h-2 rounded-full bg-amber-500 ring-2 ring-zinc-900"></span>
5058
</button>
51-
<button className="ml-2 flex items-center justify-center rounded-full overflow-hidden border-2 border-transparent hover:border-blue-500 transition-colors">
59+
<button
60+
className="ml-2 flex items-center justify-center rounded-full overflow-hidden border-2 border-transparent hover:border-blue-500 transition-colors"
61+
aria-label="User profile menu"
62+
title="User profile menu"
63+
>
5264
<div className="w-8 h-8 rounded-full bg-zinc-800"></div>
5365
</button>
5466
</div>

0 commit comments

Comments
 (0)