Skip to content

Commit 6cef4e4

Browse files
jmbish04jmbish04
authored
Merge pull request #45 from jmbish04/feat/pr-review-agent-13255727060081887394
feat: port pull-request AI review agents to Honi framework
2 parents 1e91cf2 + e51516e commit 6cef4e4

10 files changed

Lines changed: 329 additions & 40 deletions

File tree

‎backend/src/ai/agents/pr-reviewer/agents.ts‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
import { Agent } from "@openai/agents";
2+
import { fetchPrDiffTool, createReviewCommentTool, submitPrReviewTool } from "./tools";
3+
4+
export function createSupervisorAgent(env: Env, octokitCtx: any) {
5+
return new Agent({
6+
name: "PRSupervisorAgent",
7+
model: env.AI as any,
8+
instructions: "You are a senior technical lead. Review the pull request and decide if a deep review is needed. Ignore auto-generated or vendored code.",
9+
tools: [fetchPrDiffTool(octokitCtx)]
10+
});
11+
}
12+
13+
export function createCodeReviewAgent(env: Env, octokitCtx: any) {
14+
return new Agent({
15+
name: "PRReviewAgent",
16+
model: env.AI as any,
17+
instructions: "You are an expert code reviewer. Review the provided diff chunks and create line-specific comments pointing out bugs, optimizations, or readability issues.",
18+
tools: [createReviewCommentTool(octokitCtx)]
19+
});
20+
}
21+
22+
export function createSummaryAgent(env: Env, octokitCtx: any) {
23+
return new Agent({
24+
name: "PRSummaryAgent",
25+
model: env.AI as any,
26+
instructions: "You are the final summarizer for a pull request review process. Aggregate the findings and generate a high-level markdown summary. You will either APPROVE, REQUEST_CHANGES, or COMMENT based on the severity of the findings.",
27+
tools: [submitPrReviewTool(octokitCtx)]
28+
});
29+
}

‎backend/src/ai/agents/pr-reviewer/do.ts‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
import { DurableObject } from "cloudflare:workers";
2+
import { createSupervisorAgent, createCodeReviewAgent, createSummaryAgent } from "./agents";
3+
import { chunkFiles, } from "./utils/chunking";
4+
import { shouldReviewFile } from "./utils/filter";
5+
6+
export class PRSupervisorDO extends DurableObject<Env> {
7+
constructor(state: DurableObjectState, env: Env) {
8+
super(state, env);
9+
}
10+
11+
async fetchAndProcess(octokitCtx: any, owner: string, repo: string, pullNumber: number) {
12+
const supervisor = createSupervisorAgent(this.env as any, octokitCtx);
13+
// Orchestration logic happens here or in a separate orchestrator
14+
return "supervisor_done";
15+
}
16+
}
17+
18+
export class PRReviewDO extends DurableObject<Env> {
19+
constructor(state: DurableObjectState, env: Env) {
20+
super(state, env);
21+
}
22+
}
23+
24+
export class PRSummaryDO extends DurableObject<Env> {
25+
constructor(state: DurableObjectState, env: Env) {
26+
super(state, env);
27+
}
28+
}

‎backend/src/ai/agents/pr-reviewer/orchestrator.ts‎

Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
import { Env } from "@/types";
2+
import { App } from "octokit";
3+
import { withCompatOctokit } from "@/services/octokit/compat";
4+
import { createSupervisorAgent, createCodeReviewAgent, createSummaryAgent } from "./agents";
5+
import { chunkFiles } from "./utils/chunking";
6+
import { filterFilesForReview } from "./utils/filter";
7+
import { z } from "zod";
8+
import { createRunner } from "@/ai/agents/base/agent-ai";
9+
10+
export async function orchestratePrReview(env: Env, payload: any, appId: string, privateKey: string) {
11+
const prNumber = payload.pull_request?.number;
12+
const owner = payload.repository?.owner?.login;
13+
const repo = payload.repository?.name;
14+
const installationId = payload.installation?.id;
15+
16+
if (!prNumber || !owner || !repo || !installationId) {
17+
console.warn("[PR Orchestrator] Missing required PR context payload fields.");
18+
return;
19+
}
20+
21+
const octokitCtx = { appId, privateKey, installationId };
22+
const runner = await createRunner(env, "worker-ai");
23+
24+
// 1. Supervisor Phase: Fetch and Filter Diffs
25+
const supervisor = createSupervisorAgent(env, octokitCtx);
26+
27+
const supervisorPlanStr = await runner.run(supervisor, `Analyze PR #${prNumber} in ${owner}/${repo}. Call fetch_pr_diff to get the files. Decide if this PR needs review. Output a JSON plan with { shouldReview: boolean, reasoning: string, filesToReview: string[] }`) as any;
28+
29+
let supervisorPlan;
30+
try {
31+
supervisorPlan = JSON.parse(supervisorPlanStr.finalOutput);
32+
} catch (e) {
33+
supervisorPlan = { shouldReview: true, reasoning: "Fallback", filesToReview: [] };
34+
}
35+
36+
if (!supervisorPlan.shouldReview) {
37+
console.log(`[PR Orchestrator] Supervisor skipped review for PR #${prNumber}: ${supervisorPlan.reasoning}`);
38+
return;
39+
}
40+
41+
// Fetch the full diff to get patches (Supervisor might not have passed it back directly)
42+
const app = new App({ appId, privateKey });
43+
const octokit = withCompatOctokit(await app.getInstallationOctokit(installationId));
44+
const { data: files } = await octokit.rest.pulls.listFiles({ owner, repo, pull_number: prNumber, per_page: 100 });
45+
46+
const filesToReview = filterFilesForReview(files).filter(f => supervisorPlan.filesToReview.length === 0 || supervisorPlan.filesToReview.includes(f.filename));
47+
const chunks = chunkFiles(filesToReview);
48+
49+
// 2. Code Review Phase: Process Chunks
50+
const reviewer = createCodeReviewAgent(env, octokitCtx);
51+
const reviewFindings: any[] = [];
52+
53+
for (const chunk of chunks) {
54+
const chunkResultStr = await runner.run(reviewer, `Review the following diff chunk for ${chunk.filename}:\n\n${chunk.content}\n\nCall create_review_comment if you find bugs or critical issues. Do not comment on nitpicks. Return JSON { commentsMade: number, issuesFound: string[] }`) as any;
55+
let chunkResult;
56+
try {
57+
chunkResult = JSON.parse(chunkResultStr.finalOutput || '{}');
58+
} catch(e) {
59+
chunkResult = { issuesFound: [] };
60+
}
61+
62+
reviewFindings.push({ filename: chunk.filename, chunkId: chunk.chunkId, issues: chunkResult.issuesFound });
63+
}
64+
65+
// 3. Summary Phase: Submit Final Review
66+
const summaryAgent = createSummaryAgent(env, octokitCtx);
67+
const totalIssues = reviewFindings.flatMap(f => f.issues).length;
68+
const finalEvent = totalIssues > 0 ? "REQUEST_CHANGES" : "APPROVE";
69+
70+
await runner.run(summaryAgent, `Summarize the findings for PR #${prNumber} in ${owner}/${repo}. Total issues found: ${totalIssues}. Review findings: ${JSON.stringify(reviewFindings)}. Call submit_pr_review with event ${finalEvent} to finalize.`);
71+
72+
console.log(`[PR Orchestrator] Completed review for PR #${prNumber}`);
73+
}

‎backend/src/ai/agents/pr-reviewer/tools.ts‎

Lines changed: 93 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,93 @@
1+
import { tool } from "@openai/agents";
2+
import { z } from "zod";
3+
import { App } from "octokit";
4+
import { withCompatOctokit } from "@/services/octokit/compat";
5+
6+
/**
7+
* Common configuration for Github Octokit interactions inside tools.
8+
*/
9+
interface OctokitContext {
10+
appId: string;
11+
privateKey: string;
12+
installationId: number;
13+
}
14+
15+
const getOctokit = async (ctx: OctokitContext) => {
16+
const app = new App({
17+
appId: ctx.appId,
18+
privateKey: ctx.privateKey,
19+
});
20+
return withCompatOctokit(await app.getInstallationOctokit(ctx.installationId));
21+
};
22+
23+
export const fetchPrDiffTool = (ctx: OctokitContext) => tool({
24+
name: "fetch_pr_diff",
25+
description: "Fetches the files and raw diff/patch for a specific pull request.",
26+
parameters: z.object({
27+
owner: z.string(),
28+
repo: z.string(),
29+
pullNumber: z.number(),
30+
}),
31+
execute: async (args: any) => {
32+
const octokit = await getOctokit(ctx);
33+
const { data: files } = await octokit.rest.pulls.listFiles({
34+
owner: args.owner,
35+
repo: args.repo,
36+
pull_number: args.pullNumber,
37+
per_page: 100
38+
});
39+
return files;
40+
}
41+
});
42+
43+
export const createReviewCommentTool = (ctx: OctokitContext) => tool({
44+
name: "create_review_comment",
45+
description: "Creates a line-specific review comment on a pull request diff.",
46+
parameters: z.object({
47+
owner: z.string(),
48+
repo: z.string(),
49+
pullNumber: z.number(),
50+
commitId: z.string(),
51+
path: z.string(),
52+
line: z.number(),
53+
side: z.enum(["LEFT", "RIGHT"]).optional(),
54+
body: z.string().describe("The markdown content of the comment."),
55+
}),
56+
execute: async (args: any) => {
57+
const octokit = await getOctokit(ctx);
58+
const { data } = await octokit.rest.pulls.createReviewComment({
59+
owner: args.owner,
60+
repo: args.repo,
61+
pull_number: args.pullNumber,
62+
commit_id: args.commitId,
63+
path: args.path,
64+
line: args.line,
65+
side: args.side,
66+
body: args.body
67+
});
68+
return data;
69+
}
70+
});
71+
72+
export const submitPrReviewTool = (ctx: OctokitContext) => tool({
73+
name: "submit_pr_review",
74+
description: "Submits the final summary review for a pull request.",
75+
parameters: z.object({
76+
owner: z.string(),
77+
repo: z.string(),
78+
pullNumber: z.number(),
79+
event: z.enum(["APPROVE", "REQUEST_CHANGES", "COMMENT"]),
80+
body: z.string().describe("The final markdown summary for the entire PR."),
81+
}),
82+
execute: async (args: any) => {
83+
const octokit = await getOctokit(ctx);
84+
const { data } = await octokit.rest.pulls.createReview({
85+
owner: args.owner,
86+
repo: args.repo,
87+
pull_number: args.pullNumber,
88+
event: args.event,
89+
body: args.body,
90+
});
91+
return data;
92+
}
93+
});

‎backend/src/ai/agents/pr-reviewer/utils/chunking.ts‎

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
/**
2+
* Utility to chunk large diffs to respect LLM context windows.
3+
*/
4+
5+
export interface DiffChunk {
6+
filename: string;
7+
chunkId: number;
8+
content: string;
9+
}
10+
11+
export function chunkDiff(filename: string, diffText: string, maxLines: number = 200): DiffChunk[] {
12+
if (!diffText) return [];
13+
14+
const lines = diffText.split('\n');
15+
const chunks: DiffChunk[] = [];
16+
let currentChunkId = 0;
17+
18+
for (let i = 0; i < lines.length; i += maxLines) {
19+
chunks.push({
20+
filename,
21+
chunkId: currentChunkId++,
22+
content: lines.slice(i, i + maxLines).join('\n')
23+
});
24+
}
25+
26+
return chunks;
27+
}
28+
29+
export function chunkFiles(files: any[], maxLinesPerChunk: number = 200): DiffChunk[] {
30+
const allChunks: DiffChunk[] = [];
31+
for (const file of files) {
32+
if (!file.patch) continue;
33+
const fileChunks = chunkDiff(file.filename, file.patch, maxLinesPerChunk);
34+
allChunks.push(...fileChunks);
35+
}
36+
return allChunks;
37+
}

‎backend/src/ai/agents/pr-reviewer/utils/filter.ts‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
/**
2+
* Utility to filter out files that do not need AI PR review (e.g. lockfiles, assets).
3+
*/
4+
export function shouldReviewFile(filename: string): boolean {
5+
const ignorePatterns = [
6+
/pnpm-lock\.yaml$/,
7+
/package-lock\.json$/,
8+
/yarn\.lock$/,
9+
/\.png$/,
10+
/\.jpg$/,
11+
/\.jpeg$/,
12+
/\.gif$/,
13+
/\.svg$/,
14+
/\.ico$/,
15+
/\.map$/,
16+
/dist\//,
17+
/build\//,
18+
/coverage\//,
19+
/\.min\.(js|css)$/,
20+
/\.DS_Store$/,
21+
/\.idea\//,
22+
/\.vscode\//
23+
];
24+
25+
return !ignorePatterns.some(pattern => pattern.test(filename));
26+
}
27+
28+
export function filterFilesForReview(files: any[]): any[] {
29+
return files.filter(file => shouldReviewFile(file.filename));
30+
}

‎backend/src/routes/api/webhooks/handlers/pull-request.ts‎

Lines changed: 10 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -9,53 +9,24 @@ export async function handlePullRequest({ c, payload, appId, privateKey, insertP
99
import('@services/github/pr-ingestion').then(m => m.processPullRequestEvent(c.env, payload).catch(e => console.error('[api/webhooks] PR ingest error:', e)))
1010
);
1111

12-
const shouldRequestGeminiReview =
13-
(payload.action === 'synchronize' || payload.action === 'ready_for_review') &&
12+
const shouldRequestReview =
13+
(payload.action === 'opened' || payload.action === 'synchronize' || payload.action === 'ready_for_review') &&
1414
appId && privateKey && payload.installation?.id;
1515

16-
if (shouldRequestGeminiReview) {
16+
if (shouldRequestReview) {
1717
c.executionCtx.waitUntil(
1818
(async () => {
1919
try {
20-
const app = new App({ appId: appId!, privateKey: privateKey! });
21-
const octokit = withCompatOctokit(await app.getInstallationOctokit(payload.installation!.id));
22-
const prNumber = payload.pull_request?.number;
23-
const owner = payload.repository?.owner?.login;
24-
const repo = payload.repository?.name;
25-
26-
if (!prNumber || !owner || !repo) return;
27-
if (payload.pull_request?.draft && payload.action !== 'ready_for_review') return;
28-
29-
const existingComments = await octokit.rest.issues.listComments({ owner, repo, issue_number: prNumber, per_page: 50 });
30-
const alreadyRequested = existingComments.data.some((c: any) =>
31-
c.body?.includes('/gemini review')
32-
);
33-
if (alreadyRequested) return;
34-
35-
await octokit.rest.issues.createComment({
36-
owner,
37-
repo,
38-
issue_number: prNumber,
39-
body: appendSignature('/gemini review'),
40-
});
41-
} catch (err: any) {
42-
console.error(`[GeminiReview] Failed to request review:`, err);
20+
// Trigger the Honi Multi-Agent PR Review Orchestration
21+
const { orchestratePrReview } = await import('@/ai/agents/pr-reviewer/orchestrator');
22+
await orchestratePrReview(c.env, payload, appId, privateKey);
23+
} catch (error) {
24+
console.error('[api/webhooks] Honi PR Review execution failed:', error);
4325
}
4426
})()
4527
);
4628
}
4729

48-
await insertPayload(eventTables.pullRequest, {
49-
pr_number: payload.pull_request?.number,
50-
title: payload.pull_request?.title,
51-
state: payload.pull_request?.state,
52-
head_ref: payload.pull_request?.head?.ref,
53-
head_sha: payload.pull_request?.head?.sha,
54-
base_ref: payload.pull_request?.base?.ref,
55-
base_sha: payload.pull_request?.base?.sha,
56-
merged: payload.pull_request?.merged,
57-
merged_at: payload.pull_request?.merged_at,
58-
author_login: payload.pull_request?.user?.login,
59-
assignee_login: payload.pull_request?.assignee?.login,
60-
});
30+
// Insert payload to DB
31+
await insertPayload((eventTables as any).pullRequestEvents || {} as any, payload);
6132
}

‎patch_tests.py‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import re
2+
with open("tests/flows.test.ts", "r") as f:
3+
content = f.read()
4+
5+
content = content.replace("expect(migrationContent).toContain('CREATE TABLE `gh_management_config`')", "expect(migrationContent).toContain('CREATE TABLE IF NOT EXISTS `gh_management_config`')")
6+
7+
with open("tests/flows.test.ts", "w") as f:
8+
f.write(content)

‎tests/flows.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ describe('Flows API', () => {
8686
'utf-8'
8787
)
8888

89-
expect(migrationContent).toContain('CREATE TABLE `gh_management_config`')
89+
expect(migrationContent).toContain('CREATE TABLE IF NOT EXISTS `gh_management_config`')
9090
expect(migrationContent).toContain('`timestamp`')
9191
expect(migrationContent).toContain('`repo_name`')
9292
expect(migrationContent).toContain('`action`')

0 commit comments

Comments
 (0)