Skip to content

Commit d633576

Browse files
jmbish04claude
andcommitted
fix: address all Gemini code review comments on PR #457
- Use --delete-branch flag with gh pr close instead of manual Git API branch deletion (removes delete_branch function entirely) - Fix reviewer attribution in retrospective.md (remove incorrect model version) - Replace debug print() with logger.info() in generate_ux_suite.py - Note: LearningAgent IS in wrangler.jsonc v1_sentinel migration (line 470), Gemini's comment was a false positive Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 0c3ae8e commit d633576

3 files changed

Lines changed: 4 additions & 32 deletions

File tree

docs/20260329/continuous_improvement/v2/retrospective.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
> **Date:** 2026-03-31
44
> **Project:** proj-sentinel-001 — Fleet Immune System
5-
> **Reviewer:** Claude Opus 4.6 (automated code analysis)
5+
> **Reviewer:** Claude (automated code analysis)
66
> **Branch:** main (post-merge)
77
88
---

docs/20260329/continuous_improvement/v2/ux-stitch-artifacts/build-ux-automation/generate_ux_suite.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def generate_page(self, page_name: str, prompt: str):
4242
# Using your FastAPI 'scaffold_frontend' tool pattern
4343
resp = requests.post(f"{BASE_URL}/orchestration/scaffold_frontend", json=payload)
4444
resp.raise_for_status()
45-
print(resp.text)
45+
logger.info(resp.text)
4646
logger.info(f"✅ Page {page_name} successfully queued for generation.")
4747
except Exception as e:
4848
logger.error(f"❌ Failed to generate {page_name}: {e}")

scripts/github/cleanup_stale_prs.py

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@ def close_pr(pr_number: int, comment: str):
7272
print(f" ERROR commenting on #{pr_number}: {result.stderr.strip()}")
7373
return False
7474

75-
# Close PR
75+
# Close PR and delete branch
7676
result = subprocess.run(
77-
["gh", "pr", "close", str(pr_number), "--repo", REPO],
77+
["gh", "pr", "close", str(pr_number), "--repo", REPO, "--delete-branch"],
7878
capture_output=True, text=True
7979
)
8080
if result.returncode != 0:
@@ -85,31 +85,6 @@ def close_pr(pr_number: int, comment: str):
8585
return True
8686

8787

88-
def delete_branch(pr_number: int):
89-
"""Delete the remote branch for a closed PR."""
90-
if DRY_RUN:
91-
return
92-
93-
# Get branch name
94-
result = subprocess.run(
95-
["gh", "pr", "view", str(pr_number), "--repo", REPO, "--json", "headRefName", "-q", ".headRefName"],
96-
capture_output=True, text=True
97-
)
98-
if result.returncode != 0:
99-
return
100-
101-
branch = result.stdout.strip()
102-
if not branch or branch in ("main", "master"):
103-
return
104-
105-
result = subprocess.run(
106-
["gh", "api", f"repos/{REPO}/git/refs/heads/{branch}", "-X", "DELETE"],
107-
capture_output=True, text=True
108-
)
109-
if result.returncode == 0:
110-
print(f" Deleted branch: {branch}")
111-
112-
11388
def main():
11489
mode = "DRY RUN" if DRY_RUN else "LIVE"
11590
print(f"\n{'='*60}")
@@ -120,19 +95,16 @@ def main():
12095
print(f"--- Tier 1: Closing {len(TIER1_CLOSE)} stale/superseded PRs ---")
12196
for pr, comment in sorted(TIER1_CLOSE.items()):
12297
close_pr(pr, comment)
123-
delete_branch(pr)
12498

12599
# Tier 2
126100
print(f"\n--- Tier 2: Closing {len(TIER2_CLOSE)} PRs (review recommended) ---")
127101
for pr, comment in sorted(TIER2_CLOSE.items()):
128102
close_pr(pr, comment)
129-
delete_branch(pr)
130103

131104
# Tier 3
132105
print(f"\n--- Tier 3: Closing {len(TIER3_CLOSE)} remaining PRs ---")
133106
for pr, comment in sorted(TIER3_CLOSE.items()):
134107
close_pr(pr, comment)
135-
delete_branch(pr)
136108

137109
total_closed = len(TIER1_CLOSE) + len(TIER2_CLOSE) + len(TIER3_CLOSE)
138110
print(f"\n{'='*60}")

0 commit comments

Comments
 (0)