treat tuples as lists#180
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #180 +/- ##
========================================
Coverage 98.19% 98.19%
========================================
Files 14 14
Lines 1441 1441
========================================
Hits 1415 1415
Misses 26 26
Continue to review full report at Codecov.
|
|
Looks good to me, we just need to get tests added and then I'll merge this. I'm happy to write these if no one has time. |
jamesls
left a comment
jamesls
left a comment
There was a problem hiding this comment.
Looks good, we just need to add a test for this and this is good to merge.
| # Even though we can index strings, we don't | ||
| # want to support that. | ||
| if not isinstance(value, list): | ||
| if not isinstance(value, (list, tuple)): |
There was a problem hiding this comment.
Given this is duplicated below I'd suggest moving this up to line 110 and add a LIST_TYPE that we can reuse.
|
Hi. Are there any plans to have this merged soon ? |
|
If this PR is stale, I'm happy to take over and add tests to drive to closure. Anyone actively looking into this yet? |
5 participants
I believe now any tuples in input data should be treated as lists.
use case described in the issue #179 now works as expected in the issue