Commit a493d9d
committed
Fix PCCC typed write encoding bugs caught by golden tests
- EncodeDataDescriptor passed the offset ref object instead of the
offset number in the extended-type-id branch, so every typed write
whose type id needs an extension byte (notably floats, id 0x08)
threw ERR_INVALID_ARG_TYPE instead of writing
- TypedWriteRequest now rejects timer/counter/control/string/long
addresses with a clear unsupported-type error; previously the
undefined type id flowed into the descriptor encoder and produced
the same cryptic TypeError
- PCCC internal replies no longer fall through to forward() when the
context callback was already consumed
https://claude.ai/code/session_01AuAYuP6dTn8ALpkKErQuby1 parent 116a0c3 commit a493d9d
3 files changed
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
251 | | - | |
252 | 251 | | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
253 | 255 | | |
254 | 256 | | |
255 | 257 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
232 | 236 | | |
233 | 237 | | |
234 | 238 | | |
| |||
0 commit comments