Improve documentation#1
Merged
Merged
Conversation
I don't use X anymore, linking to GitHub is more appropriate.
Contributor
Author
|
Also, no elm-review init --template jfmengels/elm-review-config/package |
Contributor
Author
|
While I'm at it, I recommend that in the docs for |
jmpavlick
reviewed
Jan 11, 2025
| - Two lowercase `q`s to represent the optional maps | ||
|
|
||
| It's basically just syntactic sugar around `Maybe.andThen`; and unlike other cursed things that I hold near and dear to my heart, [@jfmengels](https://x.com/jfmengels) doesn't have an `elm-review` rule against it _yet_. | ||
| It's basically just syntactic sugar around `Maybe.andThen`; and unlike other cursed things that I hold near and dear to my heart, [@jfmengels](https://github.com/jfmengels/) doesn't have an `elm-review` rule against it _yet_. |
jmpavlick
approved these changes
Jan 11, 2025
Owner
jmpavlick
left a comment
jmpavlick
left a comment
There was a problem hiding this comment.
Damn dude, thank you so much!! Totally unexpected, but thank you for taking the time to tidy this up!
Owner
Strange enough - this is actually not working for me at the moment: $ elm-review
(node:80967) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.
(Use `node --trace-deprecation ...` to show where the warning was created)
-- CONFIGURATION COMPILATION ERROR ---------------------------------------------
Errors occurred while compiling your configuration for elm-review. I need your
configuration to compile in order to know how to analyze your files. Hopefully
the compiler error below will help you figure out how to fix it.
-- INCOMPATIBLE DEPENDENCIES ------------------------------------------ elm.json
The dependencies in your elm.json are not compatible.
Did you change them by hand? Try to change it back! It is much more reliable to
add dependencies with elm install or the dependency management tool in
elm reactor.
Please ask for help on the community forums if you try those paths and are still
having problems!However, when I ran I pushed up a branch for you: #2 Perhaps I'm holding it wrong? I figure, the least I can do give you a SSCCE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My obligatory "fixing docs while going through docs" PR. Hope this helps a bit. Feel free to take/discard what you want.
I also suggest you add a link to https://package.elm-lang.org/packages/jmpavlick/q/latest/ for this repo on GitHub.