Skip to content

fix: track transaction entry order and month activity#77

Merged
jmpompeo merged 3 commits into
mainfrom
feature/transaction-entry-order-and-month-activity
Apr 22, 2026
Merged

fix: track transaction entry order and month activity#77
jmpompeo merged 3 commits into
mainfrom
feature/transaction-entry-order-and-month-activity

Conversation

@jmpompeo

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 364f7d0e02

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +143 to +145
const summary: MonthActivitySummary = {
month: selectedMonth,
occurredAt: new Date().toISOString(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Store expense activity under the transaction's month

recordMonthActivity() always writes month: selectedMonth, but the expense form still allows saving any payload.date. If a user is viewing March and adds or edits an expense dated April, getExpensesByMonth() will move the record to April while the new activity summary is persisted under March, leaving March showing an April transaction and April with no matching activity. This summary key needs to come from the transaction date (and edits that move months may need to update both months), not the currently viewed month.

Useful? React with 👍 / 👎.

@jmpompeo jmpompeo merged commit 620a806 into main Apr 22, 2026
6 checks passed
@jmpompeo jmpompeo deleted the feature/transaction-entry-order-and-month-activity branch June 14, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant