fix: handle Plesk Obsidian 18.0.76.5+ removing --show-password (#42)

Author: jmrenouard

Changelog

@@ -29,6 +29,7 @@
 - fix: add truthiness guards to `mysql_innodb` and `mysql_stats` subroutines.
 - fix: improve `which` logic for better container/minimal environment support.
 - fix: enhance login failure reporting with detailed output.
+- fix: handle Plesk Obsidian 18.0.76.5+ removing --show-password (#42).
 - chore: automated project maintenance and cleanup (extracted `RULES.md`, `MEMORY_DB.md`, `TESTS.md`).
 - ci: migrate maintenance script to GitHub Actions.
 - chore(deps): update docker/setup-buildx-action action to v4.

mysqltuner.pl

@@ -2205,18 +2205,28 @@ sub mysql_setup {
     elsif ( -r "/etc/psa/.psa.shadow" and $doremote == 0 ) {
 
         # It's a Plesk box, use the available credentials
-        $mysqllogin =
-          "$defaults_options -u admin -p"
-          . execute_system_command("cat /etc/psa/.psa.shadow");
+        my $psa_pass = execute_system_command("cat /etc/psa/.psa.shadow");
+        chomp($psa_pass);
+        $psa_pass =~ s/'/'\\''/g;
+        $mysqllogin = "$defaults_options -u admin -p'$psa_pass'";
         my $loginstatus =
           execute_system_command("$mysqladmincmd $mysqllogin ping");
         unless ( $loginstatus =~ /mysqld is alive/ ) {
 
             # Plesk 10+
-            $mysqllogin =
-              "$defaults_options -u admin -p"
-              . execute_system_command(
+            my $plesk_pass = execute_system_command(
                 "/usr/local/psa/bin/admin --show-password");
+            chomp($plesk_pass);
+
+            # Plesk Obsidian 18.0.76.5+ no longer supports --show-password
+            if ($plesk_pass =~ /no longer supported/i || $plesk_pass =~ /--get-login-link/i) {
+                badprint
+"Attempted to use login credentials from Plesk and Plesk 10+, but they failed.";
+                exit 1;
+            }
+
+            $plesk_pass =~ s/'/'\\''/g;
+            $mysqllogin = "$defaults_options -u admin -p'$plesk_pass'";
             $loginstatus =
               execute_system_command("$mysqladmincmd $mysqllogin ping");
             unless ( $loginstatus =~ /mysqld is alive/ ) {
@@ -2241,7 +2251,8 @@ sub mysql_setup {
         $mysqlpass =~ s/passwd=//;
         $mysqlpass =~ s/[\r\n]//;
 
-        $mysqllogin = "$defaults_options -u $mysqluser -p$mysqlpass";
+        $mysqlpass =~ s/'/'\\''/g;
+        $mysqllogin = "$defaults_options -u $mysqluser -p'$mysqlpass'";
 
         my $loginstatus = execute_system_command("mysqladmin $mysqllogin ping");
         unless ( $loginstatus =~ /mysqld is alive/ ) {

releases/v2.8.41.md

@@ -29,6 +29,7 @@
 - fix: add truthiness guards to `mysql_innodb` and `mysql_stats` subroutines.
 - fix: improve `which` logic for better container/minimal environment support.
 - fix: enhance login failure reporting with detailed output.
+- fix: handle Plesk Obsidian 18.0.76.5+ removing --show-password (#42).
 - ci: enhance Quality Gate to strictly enforce zero-warning policy on GitHub Actions tests.
 - ci: implement dynamic CI test environment detection by wrapping configuration extraction.
 - ci: refactor GitHub Actions release and prerelease workflows to support dynamic versions and checksum generation.
@@ -53,6 +54,8 @@
 
 ## 🛠️ Internal Commit History
 
+- feat: finalize release 2.8.41 (c31b9fa)
+- ci: fix preflight scripts for changelog header and commitlint refname ambiguity (2bc36f9)
 - feat: release 2.8.41 (2a8371c)
 - style: tidy mysqltuner.pl (db23439)
 - ci: refactor Github release definitions with pre-releases and deliverables support (68f8d12)