ci: enforce zero-warning policy and dynamic test env

Author: jmrenouard

.github/workflows/pull_request.yml

@@ -50,7 +50,12 @@ jobs:
 
       - name: Run help mode
         run: |
-          sudo perl ./mysqltuner.pl --help
+          set -o pipefail
+          sudo perl ./mysqltuner.pl --help 2>&1 | tee output.log
+          if grep -iE 'use of uninitialized value|warning' output.log; then
+            echo "Zero-Warning Quality Gate Failed: Warnings detected in test output!"
+            exit 1
+          fi
 
   test_with_empty_db:
     needs: test_help
@@ -84,4 +89,25 @@ jobs:
 
       # Runs a single command using the runners shell
       - name: Run verbose mode
-        run: sudo perl ./mysqltuner.pl --user=root --pass=root --protocol tcp --verbose
+        run: |
+          set -o pipefail
+          sudo perl ./mysqltuner.pl --user=root --pass=root --protocol tcp --verbose 2>&1 | tee output.log
+          if grep -iE 'use of uninitialized value|warning' output.log; then
+            echo "Zero-Warning Quality Gate Failed: Warnings detected in test output!"
+            exit 1
+          fi
+
+  unit_tests:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Setup MySQL Tuner repository
+        uses: actions/checkout@v6
+
+      - name: Run unit tests
+        run: |
+          set -o pipefail
+          make unit-tests 2>&1 | tee test_output.log
+          if grep -iE 'use of uninitialized value|warning' test_output.log; then
+            echo "Zero-Warning Quality Gate Failed: Warnings detected in test output!"
+            exit 1
+          fi

Changelog

@@ -2,6 +2,8 @@
 
 2.8.41 2026-04-13
 
+- ci: enhance Quality Gate to strictly enforce zero-warning policy on GitHub Actions tests.
+- ci: implement dynamic CI test environment detection by wrapping configuration extraction.
 - fix: Restore compatibility with older Perl versions (by @jasongill).
 - feat: implement idiomatic Perl Boolean practices across the project (#34).
 - refactor: update CLI metadata to use `undef` as default for string/path options.

Makefile

@@ -127,7 +127,7 @@ test: vendor_setup
 
 test-all: vendor_setup
 	@echo "Running all MySQLTuner Lab Tests..."
-	bash build/test_envs.sh
+	bash build/test_envs.sh `perl build/get_supported_envs.pl`
 
 test-container:
 	@echo "Running MySQLTuner against container: $(CONTAINER)..."

build/get_supported_envs.pl

@@ -0,0 +1,32 @@
+#!/usr/bin/env perl
+use strict;
+use warnings;
+
+# Parses mysql_support.md and mariadb_support.md to find "Supported" versions
+# and outputs them in the format expected by multi-db-docker-env (e.g. mysql84 mariadb1011)
+
+my @configs;
+
+sub parse_support_file {
+    my ($file, $prefix) = @_;
+    return unless -f $file;
+
+    open my $fh, '<', $file or die "Cannot open $file: $!\n";
+    while (my $line = <$fh>) {
+        # Format: | 8.4 | Supported | 2024-04-30 | 2032-04-30 |
+        if ($line =~ /\|\s*([\d\.]+)\s*\|\s*Supported\s*\|/) {
+            my $version = $1;
+            $version =~ s/\.//g; # Remove dots (e.g. 8.4 -> 84, 10.11 -> 1011)
+            push @configs, "$prefix$version";
+        }
+    }
+    close $fh;
+}
+
+parse_support_file("mysql_support.md", "mysql");
+parse_support_file("mariadb_support.md", "mariadb");
+
+# Always append percona80 as a default supported engine
+push @configs, "percona80";
+
+print join(" ", @configs) . "\n";

mysqltuner.pl

@@ -2347,6 +2347,8 @@ sub mysql_setup {
                 $password = <STDIN>;
                 system("stty echo >$devnull 2>&1");
             }
+            $password = "" unless defined $password;
+            $name = "" unless defined $name;
             chomp($password);
             chomp($name);
             $mysqllogin = "$defaults_options -u $name ";
@@ -3849,7 +3851,7 @@ sub system_recommendations {
     }
     else {
         get_fs_info;
-        if ( !is_docker() && $opt{'container'} eq '' ) {
+        if ( !is_docker() && ($opt{'container'} // '') eq '' ) {
             subheaderprint "Kernel Information Recommendations";
             get_kernel_info;
         }
@@ -4474,8 +4476,10 @@ sub get_replication_status {
 
     $result{'Replication'}{'status'} = \%myrepl;
     my ($io_running) = $myrepl{'Replica_IO_Running'};
+    $io_running = '' unless defined $io_running;
     debugprint "IO RUNNING: " . ( $io_running // 'undef' ) . " ";
     my ($sql_running) = $myrepl{'Replica_SQL_Running'};
+    $sql_running = '' unless defined $sql_running;
     debugprint "SQL RUNNING: " . ( $sql_running // 'undef' ) . " ";
 
     my ($seconds_behind_replica) = $myrepl{'Seconds_Behind_Replica'};
@@ -5004,7 +5008,7 @@ sub check_storage_engines {
 sub dump_into_file {
     my $file    = shift;
     my $content = shift;
-    if ( -d "$opt{dumpdir}" && $opt{dumpdir} ) {
+    if ( defined($opt{dumpdir}) && $opt{dumpdir} ne '' && -d $opt{dumpdir} ) {
         $file = "$opt{dumpdir}/$file";
         open( FILE, ">$file" ) or die "Can't open $file: $!";
         print FILE $content;
@@ -8397,8 +8401,8 @@ sub mysql_80_modeling_checks {
     return unless mysql_version_ge( 8, 0 );
 
     my $is_mariadb = (
-             ( $myvar{'version'} =~ /MariaDB/i )
-          or ( $myvar{'version_comment'} =~ /MariaDB/i )
+             ( defined $myvar{'version'} && $myvar{'version'} =~ /MariaDB/i )
+          or ( defined $myvar{'version_comment'} && $myvar{'version_comment'} =~ /MariaDB/i )
     );
     my $header =
       $is_mariadb

tests/removed_innodb_vars.t

@@ -6,6 +6,7 @@ use Data::Dumper;
 
 # 1. Load MySQLTuner logic
 require './mysqltuner.pl';
+require './tests/MySQLTuner/TestHelper.pm';
 
 # Mocking essential globals and subroutines
 $main::good = '[OK]';
@@ -20,7 +21,8 @@ our @generalrec;
 # Test 1: MariaDB 10.6 with removed vars
 subtest 'MariaDB 10.6 Removed Variables' => sub {
     @main::generalrec = ();
-    %main::myvar = (
+    MySQLTuner::TestHelper::reset_state();
+    %main::myvar = ( %main::myvar, 
         version => '10.6.15-MariaDB',
         version_numbers => '10.6.15',
         version_comment => 'mariadb.org binary distribution',
@@ -36,7 +38,8 @@ subtest 'MariaDB 10.6 Removed Variables' => sub {
 # Test 2: MySQL 8.0 with removed vars
 subtest 'MySQL 8.0 Removed Variables' => sub {
     @main::generalrec = ();
-    %main::myvar = (
+    MySQLTuner::TestHelper::reset_state();
+    %main::myvar = ( %main::myvar, 
         version => '8.0.35',
         version_numbers => '8.0.35',
         version_comment => 'MySQL Community Server - GPL',
@@ -52,7 +55,8 @@ subtest 'MySQL 8.0 Removed Variables' => sub {
 # Test 3: MySQL 9.0 with removed vars
 subtest 'MySQL 9.0 Removed Variables' => sub {
     @main::generalrec = ();
-    %main::myvar = (
+    MySQLTuner::TestHelper::reset_state();
+    %main::myvar = ( %main::myvar, 
         version => '9.0.1',
         version_numbers => '9.0.1',
         version_comment => 'MySQL Community Server - GPL',
@@ -68,7 +72,8 @@ subtest 'MySQL 9.0 Removed Variables' => sub {
 # Test 4: MySQL 5.7 (Legacy) - should NOT warn for these vars
 subtest 'MySQL 5.7 Legacy Variables' => sub {
     @main::generalrec = ();
-    %main::myvar = (
+    MySQLTuner::TestHelper::reset_state();
+    %main::myvar = ( %main::myvar, 
         version => '5.7.44',
         version_numbers => '5.7.44',
         version_comment => 'MySQL Community Server - GPL',
@@ -83,21 +88,28 @@ subtest 'MySQL 5.7 Legacy Variables' => sub {
 # Test 5: MariaDB 10.3 (Legacy) - should NOT warn for file_format (removed in 10.6)
 subtest 'MariaDB 10.3 Legacy Variables' => sub {
     @main::generalrec = ();
-    %main::myvar = (
+    MySQLTuner::TestHelper::reset_state();
+    %main::myvar = ( %main::myvar, 
+        version => '10.3.39-MariaDB',
+        version_numbers => '10.3.39',
+        version_comment => 'mariadb.org binary distribution',
+        innodb_file_format => 'Antelope',
+    );
+    %main::real_vars = (
         version => '10.3.39-MariaDB',
         version_numbers => '10.3.39',
         version_comment => 'mariadb.org binary distribution',
         innodb_file_format => 'Antelope',
     );
-    %main::real_vars = %main::myvar;
     main::check_removed_innodb_variables();
     is(scalar @main::generalrec, 0, 'MariaDB 10.3: No warnings for innodb_file_format (not removed yet)');
 };
 
 # Test 6: Internally injected variables should NOT trigger warnings (Issue #32)
 subtest 'Injected Variables (Issue #32)' => sub {
     @main::generalrec = ();
-    %main::myvar = (
+    MySQLTuner::TestHelper::reset_state();
+    %main::myvar = ( %main::myvar, 
         version => '10.11.3-MariaDB',
         version_numbers => '10.11.3',
         version_comment => 'mariadb.org binary distribution',
@@ -114,13 +126,19 @@ subtest 'Injected Variables (Issue #32)' => sub {
 # Test 7: Variables set to 'OFF' should NOT trigger warnings (Issue #32)
 subtest 'Variables set to OFF (Issue #32)' => sub {
     @main::generalrec = ();
-    %main::myvar = (
+    MySQLTuner::TestHelper::reset_state();
+    %main::myvar = ( %main::myvar, 
+        version => '10.11.3-MariaDB',
+        version_numbers => '10.11.3',
+        version_comment => 'mariadb.org binary distribution',
+        innodb_prefix_index_cluster_optimization => 'OFF',
+    );
+    %main::real_vars = (
         version => '10.11.3-MariaDB',
         version_numbers => '10.11.3',
         version_comment => 'mariadb.org binary distribution',
         innodb_prefix_index_cluster_optimization => 'OFF',
     );
-    %main::real_vars = %main::myvar;
     main::check_removed_innodb_variables();
     is(scalar @main::generalrec, 0, "Variables set to 'OFF' do not trigger false warnings");
 };