Skip to content

Make Storage Engine Statistics output deterministic#28

Merged
jmrenouard merged 1 commit intojmrenouard:masterfrom
lewart3:each
Feb 14, 2026
Merged

Make Storage Engine Statistics output deterministic#28
jmrenouard merged 1 commit intojmrenouard:masterfrom
lewart3:each

Conversation

@lewart3
Copy link
Copy Markdown

@lewart3 lewart3 commented Feb 14, 2026

Fixes #26 Engine sizes are printed in random order in Storage Engine Statistics section

Summary by Sourcery

Bug Fixes:

  • Ensure storage engine size statistics are listed in a consistent, predictable order instead of varying between runs.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Feb 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensure the Storage Engine Statistics report engine sizes in a deterministic, sorted order instead of relying on Perl hash iteration order.

File-Level Changes

Change Details Files
Make iteration over storage engine statistics deterministic by sorting engine keys before printing.
  • Replace hash iteration using each(%enginestats) with a foreach loop over sort keys %enginestats.
  • Retrieve each engine size from the enginestats hash inside the sorted loop before printing statistics.
  • Preserve existing output formatting while guaranteeing a consistent engine order across runs.
mysqltuner.pl

Assessment against linked issues

Issue Objective Addressed Explanation
#26 Make the Storage Engine Statistics section print engine size lines in a deterministic, consistent order instead of random hash iteration order.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jmrenouard jmrenouard merged commit 747ac86 into jmrenouard:master Feb 14, 2026
4 checks passed
@lewart3 lewart3 deleted the each branch February 14, 2026 10:53
@jmrenouard
Copy link
Copy Markdown
Owner

Hi @lewart3

Thanks for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Engine sizes are printed in random order in Storage Engine Statistics section

3 participants