Skip to content

perltidy mysqltuner.pl#29

Closed
lewart3 wants to merge 0 commit intojmrenouard:masterfrom
lewart3:perltidy
Closed

perltidy mysqltuner.pl#29
lewart3 wants to merge 0 commit intojmrenouard:masterfrom
lewart3:perltidy

Conversation

@lewart3
Copy link
Copy Markdown

@lewart3 lewart3 commented Feb 14, 2026

Summary by Sourcery

Apply code style cleanup to mysqltuner.pl for consistency with perltidy formatting guidelines.

Enhancements:

  • Normalize spacing in conditional expressions and comments for improved readability.
  • Reformat JSON output printing to follow consistent line-wrapping and indentation style.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Feb 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR runs perltidy-style cleanup on mysqltuner.pl, standardizing spacing around conditionals, comment indentation, and multi-line JSON printing/pretty-print configuration, without changing behavior.

File-Level Changes

Change Details Files
Normalize spacing and formatting of conditional expressions per perltidy style.
  • Add a space after opening parentheses in elsif conditions that check for file existence
  • Add a space after opening parentheses in elsif conditions that check innodb buffer pool chunk size definitions and values
mysqltuner.pl
Fix indentation of a comment in the mariadb_xtradb subroutine to align with surrounding code style.
  • Re-indent the 'Not implemented' comment under mariadb_xtradb so it aligns at the same level as other statements in the block
mysqltuner.pl
Reformat JSON encoding and printing to use clearer multi-line method chaining while preserving logic.
  • Split chained JSON->utf8()->pretty()->encode() calls across multiple lines for STDOUT printing
  • Apply the same multi-line formatting to JSON printing to an output file handle
mysqltuner.pl

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant