Fix wsrep_slave_threads deprecation #819#7
Conversation
As wsrep_slave_threads is not set to anything on new MySQL versions it seems to guess on a value, maybe wsrep_applier_threads should be used instead when wsrep_slave_threads is not found. Deprecated as of MySQL-wsrep 8.0.26-26.8 in favor of [wsrep_applier_threads] This commit refactors the mariadb_galera subroutine to handle both wsrep_slave_threads and wsrep_applier_threads variables. This ensures the script provides accurate recommendations for different MySQL versions. The get_wsrep_options subroutine has also been refactored to remove the logic that adds wsrep_slave_threads to the @galera_options array, as it is a server variable, not a Galera provider option.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
jmrenouard
changed the title
1 participant
As wsrep_slave_threads is not set to anything on new MySQL versions it seems to guess on a value, maybe wsrep_applier_threads should be used instead when wsrep_slave_threads is not found.
Deprecated as of MySQL-wsrep 8.0.26-26.8 in favor of [wsrep_applier_threads]
https://galeracluster.com/library/documentation/mysql-wsrep-options.html#wsrep-slave-threads
PR created automatically by Jules for task 9378261833438112953