Skip to content

Fix PASSWORD() function error on MySQL 8+#8

Merged
jmrenouard merged 1 commit into
masterfrom
fix-mysql8-password-function
Oct 6, 2025
Merged

Fix PASSWORD() function error on MySQL 8+#8
jmrenouard merged 1 commit into
masterfrom
fix-mysql8-password-function

Conversation

@google-labs-jules

Copy link
Copy Markdown

This change fixes an issue where MySQLTuner would produce errors when run against MySQL 8.0 and later. The errors were caused by the use of the PASSWORD() function, which has been removed in MySQL 8.

The fix involves adding specific version checks around the parts of the code that use the PASSWORD() function. This prevents the errors from occurring on newer MySQL versions while still allowing the relevant security checks to run on older, compatible versions.


PR created automatically by Jules for task 17340461761559591539

The `PASSWORD()` function was removed in MySQL 8.0, causing errors when running MySQLTuner against newer versions of MySQL.

This commit addresses the issue by wrapping the specific code blocks that use the `PASSWORD()` function in a version check (`if (!mysql_version_ge(8))`).

This change ensures that:
- The script no longer produces errors on MySQL 8.0 and later.
- Security checks that do not rely on the `PASSWORD()` function are still executed on MySQL 8+, which is an improvement over the previous broader check that skipped the entire security section.
@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

@jmrenouard jmrenouard marked this pull request as ready for review October 6, 2025 21:38
@jmrenouard jmrenouard merged commit 3c19f78 into master Oct 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant