Skip to content

Commit 6153797

Browse files
authored
Merge pull request #142 from joalla/fix_readthedocs
Fix readthedocs builds, update copyright year & Writing Docs page
2 parents 41aae5e + ce0c223 commit 6153797

5 files changed

Lines changed: 29 additions & 16 deletions

File tree

.readthedocs.yaml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
version: 2
2+
3+
build:
4+
os: ubuntu-22.04
5+
tools:
6+
python: "3.11"
7+
8+
sphinx:
9+
configuration: docs/source/conf.py
10+
11+
python:
12+
install:
13+
- method: pip
14+
path: .
15+
extra_requirements:
16+
- docs

docs/source/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
# -- Project information -----------------------------------------------------
1919

2020
project = 'python3-discogs-client'
21-
copyright = '2020-2022, The Joalla Team'
21+
copyright = '2020-2024, The Joalla Team'
2222
author = 'The Joalla Team'
2323

2424
# The full version, including alpha/beta/rc tags

docs/source/writing_docs.md

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,10 @@ git clone <git url>
1212

1313
## Install Prerequisites
1414

15-
Install Sphinx
15+
Being located in the root of the repo, install Sphinx and its requirements.
1616

1717
```
18-
pip install -r sphinx_requirements.txt
19-
```
20-
21-
Install python3-discogs-client itself into your (virtual) development environment. This is required by Sphinx autodoc:
22-
23-
```
24-
python setup.py develop
18+
pip install -e '.[docs]'
2519
```
2620

2721
## Edit Files
@@ -38,9 +32,9 @@ Almost all documentation is written using the Markdown format. The exception is
3832

3933
## Build the Documentation
4034

41-
After your changes are complete, you can build the documentation by running the ```make html``` command. This will build the documentation in the ```docs/build/html``` directory.
35+
To build the documenation on your local machine change into the ```docs/``` directory and run ```make html```. Find the output in the ```docs/build/html``` directory.
4236

43-
Please note that as of this writing, Python 3.10 will not work. Please use Python Python >=3.6 and <=3.9 when building the documentation.
37+
We recommend using Python 3.9 or Python 3.11 for building the documentation.
4438

4539
Check the command line input to make sure no errors occurred. If there is an error, fix it, and re-run the command. You can ignore warnings similar to this one:
4640

setup.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,11 @@
2929
packages=[
3030
'discogs_client',
3131
],
32-
)
32+
extras_require={
33+
"docs": [
34+
"sphinx",
35+
"sphinx-rtd-theme",
36+
"myst-parser",
37+
],
38+
}
39+
)

sphinx_requirements.txt

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)