Some cosmetic issues

[AndyM48]

When loyaltyCards opens for the first time it shows a completely blank screen,

after the first click it shows a partial (obscured) list

the full list should be displayed

[AndyM48]

Clicking (touching) the lower part of the screen creates a new, blank, window

[AndyM48]

With a long list of cards, the screen shrinks so that everything fits on the screen.

The list should probably run off the bottom of the screen. A card could be selected using the Search Cards option, or scrolling through the list with up and down motions.

Selecting a card shows the card information at the bottom of the list.

making the list very small on the phone.

It may be better to open the selected card's information in the pop up window?

[AndyM48]

"Entry Cards" should read "Enter Cards"

I have been eable to enter the card numbers in the groups indicated on the cards themselves by changing line 129 from
codebar = row[1].strip() to codebar = row[1].replace(" ", "")

Sorry about all the comments, but I thought it easier if I split them up

[joanisc]

Hi @FDServices ,

I think it's a good for the reader to group barcodes in groups of four. I'll implement that. Thanks for the example.
It's the intended use to show it blank when starting. The idea was to not show anything until you search or interact with the screen. I do not know if it make sense but it feels more clean to me. I'll try to correct the showing partial that you said on your first post.
It is what I wanted to show a preview of the pictures of each card when one is selected. And when touching an image preview open that picture/barcode in a bigger screen to show at the store for example.

So the filtered list of card should be limited to what you have searched or 5 results for example. Pending to implement the limit and the scroll if the filtered number of cards is bigger than 5 because I couldn't achieve to put an scroll to a listbox object, and when achieved I cannot achieve to make the listbox rows clickable.

The flow that I though when created the app was:

1. Entry the card info
2. Be able to search your entered card
3. Show a preview of the info.
4. Show the images in bigger touching if you need it

Do you thing it is better another approach?

I'm doing an effort to invest time on what you say, but I am not able to follow your rhythm.

[joanisc]

Clicking (touching) the lower part of the screen creates a new, blank, window

This is due the ability that did yesterday to have cards without image... The app try to make bigger the non existing image in a pop up. I will try to correct.

[joanisc]

I think the UI of the app can be changed to get things be smother. Using buttons instead of Gtk.Notebook and using gnome-builder to do the UI.
On the long way I was thinking on doing a version 2 of the app based on a branch of gnome safe password...

[AndyM48]

I'm doing an effort to invest time on what you say, but I am not able to follow your rhythm.

So I imagine that I am at the cash desk, waiting to pay for my shopping. The cashier asks for my loyalty card:

Open the phone
Touch loyaltyCardsOpen icon
Select the correct loyalty card - it is displayed. (*)
Turn phone to cashier for the barcode to be scanned.

Clearly the quicker this can happen the better.

• The card could be displayed in the pop-up window instead of at the foot of the list, which would solve a number of the problems with the display.
  Now I wonder what happens if I have selected the wrong card? Could I swipe left for the next card or swipe right for the previous card?

IMHO loyaltyCardsOpen is close to being a very good app. I would not be looking to a version 2 at the moment :)

[joanisc]

I achieved to have an scroll for the list of cards and my next approach is let the user be able to change the kind of view. With or without photos preview. And I will try to show the list of cards on start avoiding an extra touch as you said.
Thank you for your code and comments.

[joanisc]

Now the list of cards is automatically shown when the app is opened