Skip to content

Commit 21cb2a9

Browse files
joaoh82claude
andauthored
fix(release): bump sqlrite-journal example in bump-version.sh (#152)
The `sqlrite-journal` desktop example (examples/desktop-journal/src-tauri) is a workspace member that pins `sqlrite-engine` via a path+version dep, but it was never added to bump-version.sh's file lists. Patch releases survived because its `^0.10.1` pin still matched `0.10.x`, but the first minor bump (0.11.0) falls outside `^0.10.1`, so the Release-PR workflow's workspace lock refresh failed: error: failed to select a version for the requirement `sqlrite-engine = "^0.10.1"` … required by package `sqlrite-journal` (release-pr run 26737256013, dispatching v0.11.0.) Add it to TOML_FILES so both its package version and its engine dep pin track every bump — the same full-bump treatment desktop/src-tauri already gets. Verified locally: `bump-version.sh 0.11.0` now rewrites the journal manifest and `cargo build --workspace --exclude sqlrite-desktop --exclude sqlrite-journal` (the exact CI lock-refresh step) resolves cleanly. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 05fd59c commit 21cb2a9

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

scripts/bump-version.sh

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
# scripts/bump-version.sh 0.2.0
77
#
88
# Rewrites the version field in every manifest that carries one
9-
# (nine Cargo.toml / pyproject.toml files, plus four JSON manifests
10-
#thirteen files total). Also rewrites the engine npm dep pin in
9+
# (ten Cargo.toml / pyproject.toml files, plus four JSON manifests
10+
#fourteen files total). Also rewrites the engine npm dep pin in
1111
# `examples/nodejs-notes/package.json` so the published example
1212
# resolves the matching engine. Then you run `cargo build` yourself
1313
# to refresh Cargo.lock. Idempotent: running twice with the same version
@@ -77,6 +77,16 @@ TOML_FILES=(
7777
"sdk/nodejs/Cargo.toml"
7878
"sdk/wasm/Cargo.toml"
7979
"desktop/src-tauri/Cargo.toml"
80+
# `sqlrite-journal` is the second Tauri desktop app (the
81+
# concurrent-writes journal example, SQLR-43). It's a workspace
82+
# member that pins `sqlrite-engine` via a path+version dep, so —
83+
# exactly like `desktop/src-tauri` — both its package version and
84+
# that dep pin have to track the bump. Omitting it survived patch
85+
# releases (a `^0.10.1` pin still matched `0.10.x`) but broke the
86+
# first MINOR bump: `0.11.0` falls outside `^0.10.1`, so the
87+
# workspace lock refresh failed to select a version (release-pr run
88+
# 26737256013). Keep it here so the dep pin never lags the engine.
89+
"examples/desktop-journal/src-tauri/Cargo.toml"
8090
)
8191

8292
# Files that pin `sqlrite-engine` (or any other workspace member) but

0 commit comments

Comments
 (0)