ci(release): exclude sqlrite-journal from release-pr lock refresh#147
Merged
Conversation
#145 added `examples/desktop-journal/src-tauri` (package `sqlrite-journal`, a Tauri/GTK crate) as a workspace member and updated ci.yml's build/test/clippy/doc steps to `--exclude sqlrite-journal`, but release-pr.yml's "Refresh Cargo.lock" step was missed. So `cargo build --workspace --exclude sqlrite-desktop` tried to compile sqlrite-journal → glib-sys on a runner without the GTK system libs, failing the first release-PR dispatch since #145 merged. Mirror ci.yml: also exclude sqlrite-journal here. Lock-refresh only needs to resolve versions, not build the desktop/journal apps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dispatching the Release PR workflow (
release-pr.yml) for0.10.2failed in the Refresh Cargo.lock step (run 26697159818):Root cause (not the SQLR-70 change)
#145 added
examples/desktop-journal/src-tauri(packagesqlrite-journal, a second Tauri/GTK crate) as a workspace member. It correctly updated ci.yml's build/test/clippy/doc steps to--exclude sqlrite-journal— but the release-pr.yml lock-refresh step was missed. So:now tries to compile
sqlrite-journal→glib-sys, which fails on the runner (no GTK/glib system libs installed). CI stayed green because it excludes the journal everywhere; this only surfaced on the first release-PR dispatch since #145 merged.Fix
Mirror ci.yml — also
--exclude sqlrite-journalin the lock-refresh step. That step only needs to resolve versions intoCargo.lock, not build the desktop/journal apps.release.ymlwas checked and has no equivalent barecargo build --workspacestep (itspublish-desktopjob installs the Tauri Linux deps and builds viatauri-action), so no change is needed there.After merge
Re-dispatch
release-pr.ymlfor0.10.2(the original SQLR-70 release).🤖 Generated with Claude Code